From 07d9e449c66b24f642c59b04271950e7d78c2b4b Mon Sep 17 00:00:00 2001 From: manumafe98 Date: Mon, 29 Jan 2024 22:29:24 -0300 Subject: [PATCH 1/3] Adding jq check of the exercise status to test runner --- bin/test-with-test-runner | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/bin/test-with-test-runner b/bin/test-with-test-runner index 4de430ede..e3bab9f61 100755 --- a/bin/test-with-test-runner +++ b/bin/test-with-test-runner @@ -34,6 +34,12 @@ function verify_exercise() { local implementation_files=($(jq -r --arg d "${dir}" --arg k "${implementation_file_key}" '$d + "/" + .files[$k][]' "${dir}/.meta/config.json")) local stub_files=($(jq -r --arg d "${dir}" '$d + "/" + .files.solution[]' "${dir}/.meta/config.json")) local results_file="${output_dir}/results.json" + local exercise_type=$3 + local exercise_status=($(jq -r --arg t ${exercise_type} --arg s ${slug} '.exercises[$t][] | select(.slug == $s).status' config.json)) + + if [ "$exercise_status" == "deprecated"]; then + return + fi mkdir -p "${output_dir}" @@ -65,7 +71,7 @@ function verify_exercise() { for concept_exercise_dir in ./exercises/concept/*/; do if [ -d $concept_exercise_dir ]; then echo "Checking $(basename "${concept_exercise_dir}") exercise..." - verify_exercise $concept_exercise_dir "exemplar" + verify_exercise $concept_exercise_dir "exemplar" "concept" fi done @@ -73,7 +79,7 @@ done for practice_exercise_dir in ./exercises/practice/*/; do if [ -d $practice_exercise_dir ]; then echo "Checking $(basename "${practice_exercise_dir}") exercise..." - verify_exercise $practice_exercise_dir "example" + verify_exercise $practice_exercise_dir "example" "practice" fi done From 74deda89da197293a025de58c14e38f0d914ce93 Mon Sep 17 00:00:00 2001 From: manumafe98 Date: Mon, 29 Jan 2024 22:43:30 -0300 Subject: [PATCH 2/3] Fix if statement typo --- bin/test-with-test-runner | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/test-with-test-runner b/bin/test-with-test-runner index e3bab9f61..0c146c8b7 100755 --- a/bin/test-with-test-runner +++ b/bin/test-with-test-runner @@ -37,7 +37,7 @@ function verify_exercise() { local exercise_type=$3 local exercise_status=($(jq -r --arg t ${exercise_type} --arg s ${slug} '.exercises[$t][] | select(.slug == $s).status' config.json)) - if [ "$exercise_status" == "deprecated"]; then + if [[ $exercise_status == "deprecated" ]]; then return fi From b025a5f375800ad158362930838d9670f4012b7e Mon Sep 17 00:00:00 2001 From: manumafe98 Date: Tue, 30 Jan 2024 09:37:31 -0300 Subject: [PATCH 3/3] Adding comment when skipping deprecated exercise --- bin/test-with-test-runner | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/test-with-test-runner b/bin/test-with-test-runner index 0c146c8b7..eed2d74b0 100755 --- a/bin/test-with-test-runner +++ b/bin/test-with-test-runner @@ -38,6 +38,7 @@ function verify_exercise() { local exercise_status=($(jq -r --arg t ${exercise_type} --arg s ${slug} '.exercises[$t][] | select(.slug == $s).status' config.json)) if [[ $exercise_status == "deprecated" ]]; then + echo "Skipping deprecated exercise: ${slug}" return fi