From 51cb106214eaa875ecc0d774d21b18484ac7d472 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Tue, 19 Mar 2024 09:47:49 +0100 Subject: [PATCH 1/2] Don't fiddle with upstream files --- .prettierignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.prettierignore b/.prettierignore index eb205c2108..1306859a0c 100644 --- a/.prettierignore +++ b/.prettierignore @@ -1,5 +1,6 @@ /.github/labels.yml /.github/workflows/sync-labels.yml +/.github/workflows/no-important-files-changed.yml exercises/**/README.md !/README.md From f643f477789470456f343ac4c40c63007d3e2257 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sat, 25 May 2024 13:41:51 +0200 Subject: [PATCH 2/2] Provide more helpful test output --- .../dnd-character/dnd-character.spec.js | 27 +++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/exercises/practice/dnd-character/dnd-character.spec.js b/exercises/practice/dnd-character/dnd-character.spec.js index 43d560a161..b9aa0bbcda 100644 --- a/exercises/practice/dnd-character/dnd-character.spec.js +++ b/exercises/practice/dnd-character/dnd-character.spec.js @@ -84,21 +84,44 @@ describe('D&D Character', () => { expect(Character.rollAbility()).toBeGreaterThanOrEqual(3); }); - xtest('random character is valid', () => { + xtest('random character is valid - strength', () => { const Drizzt = new Character(); - expect(Drizzt.strength).toBeLessThanOrEqual(18); expect(Drizzt.strength).toBeGreaterThanOrEqual(3); + }); + + xtest('random character is valid - dexterity', () => { + const Drizzt = new Character(); expect(Drizzt.dexterity).toBeLessThanOrEqual(18); expect(Drizzt.dexterity).toBeGreaterThanOrEqual(3); + }); + + xtest('random character is valid - constitution', () => { + const Drizzt = new Character(); expect(Drizzt.constitution).toBeLessThanOrEqual(18); expect(Drizzt.constitution).toBeGreaterThanOrEqual(3); + }); + + xtest('random character is valid - intelligence', () => { + const Drizzt = new Character(); expect(Drizzt.intelligence).toBeLessThanOrEqual(18); expect(Drizzt.intelligence).toBeGreaterThanOrEqual(3); + }); + + xtest('random character is valid - wisdom', () => { + const Drizzt = new Character(); expect(Drizzt.wisdom).toBeLessThanOrEqual(18); expect(Drizzt.wisdom).toBeGreaterThanOrEqual(3); + }); + + xtest('random character is valid - charisma', () => { + const Drizzt = new Character(); expect(Drizzt.charisma).toBeLessThanOrEqual(18); expect(Drizzt.charisma).toBeGreaterThanOrEqual(3); + }); + + xtest('random character is valid - hitpoints', () => { + const Drizzt = new Character(); expect(Drizzt.hitpoints).toEqual(10 + abilityModifier(Drizzt.constitution)); });