Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fixes for exercises: complex-numbers, etl, gigasecond #539

Merged
merged 3 commits into from Oct 30, 2018

Conversation

Projects
None yet
2 participants
@trvrfrd
Copy link
Contributor

commented Oct 30, 2018

For issue #480

Bundled up a few simple ESLint fixes in one convenient PR.

complex-numbers:

javascript/exercises/complex-numbers/complex-numbers.spec.js
  45:1  error  Trailing spaces not allowed  no-trailing-spaces

javascript/exercises/complex-numbers/example.js
   1:36  error  Block must not be padded by blank lines  padded-blocks
  19:58  error  Expected newline before ')'              function-paren-newline
  27:64  error  Expected newline before ')'              function-paren-newline
  41:48  error  Expected newline before ')'              function-paren-newline

etl:
(I actually don't love these changes, but they make ESLint happy)

javascript/exercises/etl/etl.spec.js
  13:22  error  Expected a line break after this opening brace   object-curly-newline
  13:53  error  Expected a line break before this closing brace  object-curly-newline
  20:22  error  Expected a line break after this opening brace   object-curly-newline
  20:47  error  Expected a line break before this closing brace  object-curly-newline

gigasecond:

javascript/exercises/gigasecond/example.js
  3:27  error  Expected parentheses around arrow function argument having a body with curly braces  arrow-parens
  6:2   error  Missing semicolon                                                                    semi

Happy to squash this into one commit if deemed appropriate.

Thank you for your time!

@matthewmorgan

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

@trvrfrd looks awesome, thanks for helping us clean this up. One request, if you don't mind...

@trvrfrd trvrfrd force-pushed the trvrfrd:lint-fixes branch from cd9bebf to e7a353e Oct 30, 2018

@matthewmorgan matthewmorgan merged commit a38f3a6 into exercism:master Oct 30, 2018

2 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthewmorgan

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

Thanks @trvrfrd !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.