rational-numbers: Make formulas more readable #1655

SaschaMann · 2020-05-04T23:03:42Z

This makes the given formulas easier to read, by using a₁ instead of a1 etc.

I don't know if this is covered by #1560, please turn it into a draft if it is.

coriolinus · 2020-05-04T23:32:04Z

Tests which have been performed, checked if the numbers display correctly

Tests that I have not performed, which would be of interest

OSX terminal
Ubuntu terminal
Iphone / Ipad

I assume that most browsers and coding editors will properly support unicode characters; I think the testing priority should be terminals. Still, tests of all kinds are of interest.

The only failure so far has been using type on the command prompt in Windows. I imagine that this represents a small enough portion of the user population that we can accept that failure, particularly as notepad succeeds and is built into that OS. Data would be helpful, but may be unavailable.

I'm a bit concerned about readability, particularly for the superscript characters. Perhaps I am abnormal, but I keep my terminal font sized as small as is comfortable to read for an extended time. What this means is that b^m is comfortable for me to read, but bᵐ is not. Yes, it's easy to just expand the text in most environments these days, but I'd still prefer to avoid the necessity.

My personal inclination is against this PR, with regret. It's nice to have real mathematical notation, but it's even nicer to be able to read the text without squinting; the readability concern--which, as previously stated, may exist only for me--tips my vote.

SaschaMann · 2020-05-04T23:51:37Z

Thanks a lot for testing!

The only failure so far has been using type on the command prompt in Windows. I imagine that this represents a small enough portion of the user population that we can accept that failure, particularly as notepad succeeds and is built into that OS. Data would be helpful, but may be unavailable.

The Windows command prompt is being replaced with a terminal that has much better unicode support, so this will mostly affect legacy Windows systems in the not so distant future.

I'm a bit concerned about readability, particularly for the superscript characters. [...] the readability concern--which, as previously stated, may exist only for me--tips my vote.

Would you be fine with the PR if only the subscript characters were introduced? I mostly care about b1 being replaced with b₁, ^m is less of an issue imo and I'd be more than happy to drop those changes if that means the rest would be accepted.

One more thing to be tested: How will this work on screen readers? I know maths rendered with MathJax should work fine, but I'm unsure about something like this.

rpottsoh · 2020-05-05T02:37:29Z

I messed around with the file in Windows and the best end result I ended up with is all the subscripts reverted back to pre-PR state.

If I list the raw file in Chrome browser window and copy and paste file contents to Notepad the contents of the file in Notepad appear correct. However when I save the file Notepad puts up a prompt that unless I change the encoding to UTF8 the file will be stored as ANSI; I don't see an obvious way to make this suggested setting change in Notepad.
I next tried pasting the file into Notepad++, none of the subscripts appeared correctly. With more tinkering maybe this could be made to work.
My final test was to copy the console to a file. At the command prompt I executed copy con filename.md and then proceeded to paste from the web browser the raw contents of the file. In the cmd window the contents appeared correctly. Upon closing the file and I then executed type filename.md the results were ANSI :(

It may be possible to have the changes appear correctly in Windows but it isn't cut and dry.....

Personally speaking I am OK with the changes.

kotp · 2020-05-05T06:14:56Z

Notepad on Windows seems to do OK, from reports.

coriolinus · 2020-05-05T07:01:41Z

Would you be fine with the PR if only the subscript characters were introduced?

Yes, I would.

SaschaMann · 2020-05-05T09:16:47Z

Would you be fine with the PR if only the subscript characters were introduced?

Yes, I would.

I've removed them.

coriolinus

I also don't know if this is covered by #1560, but for what it's worth, I think this change looks good. Still, please don't merge until someone in a position to determine makes a judgement about whether it's allowed to be merged, by policy.

kotp · 2020-05-05T15:58:11Z

@coriolinux and @SaschaMann Do you think we should convert this to draft as well?

yawpitch

I would not consider this blocked by #1560, as it's a doc improvement, however I'd defer to @iHiD or @kytrinyx regarding inclusion of non-ASCII characters in this repo's description.md files ... we have no idea the size of the matrix of possible configurations of OS / text editor / locale that might be used by students, and considering the breadth of both low-level and quite old languages we cater to I could imagine that there are tracks that might have a problem with this in the V2 "download and work on it" model. Personally I prefer the subscript, but I wouldn't want to be the student who just saw some funny bytes.

I would, however, object to the removal of the parentheses on lines 13, 15, and 17, especially while similar use of parentheses remains on 5,7,9, and 11 ... while I can tell at a glance that exponentiation binds before division, that's simply not obvious to all our students, many of whom already struggle with the more "mathy" exercises.

rpottsoh · 2020-05-07T14:04:03Z

I might have to reverse my positive opinion on this change because #441. It speaks to test cases but I think is applicable here.

SaschaMann · 2020-05-07T14:55:08Z

I would, however, object to the removal of the parentheses on lines 13, 15, and 17, especially while similar use of parentheses remains on 5,7,9, and 11 ... while I can tell at a glance that exponentiation binds before division, that's simply not obvious to all our students, many of whom already struggle with the more "mathy" exercises.

I forgot to undo that when removing the superscripts. Thanks for pointing that out.

exercises/rational-numbers/description.md

SaschaMann · 2020-05-07T14:59:51Z

exercises/rational-numbers/description.md


-Dividing a rational number `r1 = a1/b1` by another `r2 = a2/b2` is `r1 / r2 = (a1 * b2) / (a2 * b1)` if `a2 * b1` is not zero.
+Dividing a rational number `r₁ = a₁/b₁` by another `r₂ = a₂/b₂` is `r₁ / r₂ = (a₁ * b₂) / (a₂ * b₁)` if `a₂ * b₁` is not zero.


Suggested change

Dividing a rational number `r₁ = a₁/b₁` by another `r₂ = a₂/b₂` is `r₁ / r₂ = (a₁ * b₂) / (a₂ * b₁)` if `a₂ * b₁` is not zero.

Dividing a rational number `r₁ = a₁/b₁` by another `r₂ = a₂/b₂` is `r₁ / r₂ = (a₁ * b₂) / (a₂ * b₁)` if `a₂` is not zero.

This might belong in a different PR, so I'll just leave it as a suggestion. If b₁ = 0, then r₁ is not a rational number anyway.

iHiD · 2020-05-07T15:03:29Z

Thanks for the tag, @yawpitch. So, I'm happy for this to be merged in terms of #1560. But I have zero knowledge of the impact of this across systems. I'm happy that the website itself can render it, but can people read it when downloaded across systems (what @yawpitch said basically)? So, who here knows about this stuff and how it might be problematic? And then, after highlighting ways it might go wrong, how can we test the impact of this in READMEs across different systems? Get a Docker of Windows 3.1 and roll the dice? :) I'll need one of you to give me more guidance here, but I would like to get this merged if we can prove it's non-damaging.

coriolinus · 2020-05-07T21:00:30Z

I've seen several suggestions for targets which should be tested before this is merged. Collecting them:

OSX terminal
Ubuntu terminal
Android
Iphone / Ipad
screen readers (windows/mac/linux default ones?)
Old Windows (via Docker or vmware, probably)

I think it is a good idea to test all of these platforms. However, I don't think any single failure other than the screen readers should automatically veto this PR; what matters isn't so much the number of systems for which this doesn't work, as the number of people who can't get a legible representation of the file.

I'm not convinced by the argument that people using low-level or old languages will be unwilling or unable to use modern tooling: if I were to attempt to pick up cobol or fortran, my first step after installing the compiler would be to install the appropriate plugin into VS Code, which is known to display these characters properly.

how can we test the impact of this in READMEs across different systems

This is the crux of the problem. I can see what amounts to two approaches possible:

Perform a study: create an exercise called "Exercism Survey" with a README containing unicode, and a single test, whose name is "any character in the README render improperly for you", and which accepts any boolean. Inject it into all tracks, unlocked immediately. Collect the results, tabulate them once a few hundred have come in. This inconveniences no students, and someone could probably publish a legitimate paper on "Prevalence of Unicode-Compatible Editors In Programming Students" from the data. It would take non-trivial work from all maintainers, though.
YOLO it: test the matrix of viewers that we can think of. If sufficient of them pass, merge this PR, wait for bug reports. If we see, say, half a percent of students filing bug reports about this, we can revert the PR.

My personal preference leans toward the second option, because I suspect that the number of people truly inconvenienced by this PR will be exceedingly low.

iHiD · 2020-05-07T21:27:45Z

Yeah - I'm all up for YOLO here and agree with your post in general, @coriolinus. As long as we get some breadth of types, I'm good to go.

So everyone, let's call this list canonical. If there are things missing from there, please say and @coriolinus can add. If you can test one (positively or negatively) please say and @coriolinus can update.

SaschaMann · 2020-05-07T21:32:14Z

Android
Iphone / Ipad

The CLI doesn't support these systems, so presumably they'd have to go through a browser to download them anyway?

They are displayed without issues in Firefox on Android for me, however in mobile Chrome, only the ₂ renders, the ₁ is a block (wat?). I'm not sure how relevant that is to the overall distribution. @iHiD since mobile Chrome doesn't support adblockers, Google Analytics probably has an accurate picture of how many people that would affect (if any).

iHiD · 2020-05-07T21:34:37Z

They are displayed without issues in Firefox on Android for me, however in mobile Chrome, only the 2 renders, the 1 is a block (wat?). I'm not sure how relevant that is to the overall distribution.

So. This is probably/maybe/possible because each different OS renders its native font for v2. In v3, this will probably change.

@iHiD since mobile Chrome doesn't support adblockers, Google Analytics probably has an accurate picture of how many people that would affect (if any).

11% of our traffic is mobile Chrome.

yawpitch · 2020-05-08T11:32:23Z

We might want to consider Linux distros outside Ubuntu ... I run Arch and X and the subscripts render fine (if extremely small) in my virtual terminal in vi, nano, etc ... but if I drop out of X and use the system console they all render as unknown blocks.

Now, admittedly, most people I know use X or Wayland, but I do know people who boot to the console and only kick of an X session when they're browsing or otherwise forced into a GUI.

SaschaMann · 2020-10-13T12:27:51Z

@iHiD is this covered by #1686's "All PRs that were on hold can be merged (many will probably need updating in line with immutability)."?

iHiD · 2020-10-13T14:20:24Z

Yes. They still need the there green ticks though.

@rpottsoh - you reversed your approval. I'm personally ok with this because I think the reason that #441 made those rules was for the languages that have implement the test cases, not the READMEs themselves. Do you still feel this is inappropraite?

SaschaMann · 2020-10-28T22:10:57Z

@iHiD it's been more than 14 days, can we merge this?

iHiD · 2020-10-28T23:04:02Z

I'm going to say yes, and merge. But reserve the right to revert if we decide it was a bad idea in the future :)

@SaschaMann

* resistor-color-duo: add test case to ignore additional colors (exercism#1569) resistor-color-duo: ignore additional colors * [Space Age] Put Earth in it's proper order - Move Earth into its proper position in the solar system - Make wording more consistent * Remove commas from seconds amount Co-Authored-By: Victor Goff <keeperotphones@gmail.com> * Add data structures to topic list We have a number of exercises that are about data structures, but the topic was missing. * Scrabble is a trademark name. It should be capitalized. It is also a noun, meaning a "doodle", and a verb, such as what this description could be considered. In our case, we are referring to the trademarked name of the game Scrabble. Signed-off-by: Victor Goff <keeperotphones@gmail.com> * Add testcase * Matrix: Add symmetric test cases for non-square matrices * matrix: fix whitespace issue (exercism#1578) * matrix: fix whitespace issue Fix whitespace issue introduced by exercism#1576, closes $1577. * Matrix: bump version number. * leap: Add years that refute some unusual factors (exercism#1581) leap 1.6.0 Some implementations unexpectedly pass the entire test suite: * Replacing 4 with 499, 998, or 1996 * Replacing 100 with 5, 10, or 20 * Replacing 100 with 3, 6, 12, 15, 30, 60, 75, 150, 300 * Replacing 400 with 125, 250, 500, 1000, or 2000 Adding these test cases would correctly point out that these solutions are incorrect. I think it's a bit unusual since no student is going to write such an implementation except a student deliberately trying to slip past the tests. Or maybe a student trying to micro-optimise? Maybe they are trying to test whether division by small numbers is faster than division by large numbers? But discussion participants have deemed that the cost of three tests is worth the benefit of reducing mental overhead of mentors, since such solutions have in fact been seen in the wild. * Add micro-blog exercise (exercism#1509) * Add micro-blog exercise This is an exercise requiring students to truncate unicode strings. Solves exercism#1507 * Micro-blog: Don't assume native English speaker Thank you @SaschaMann for the feedback and suggestion. exercism#1509 (comment) > I don't like that this assumes the perspective of a native English > speaker. English is a foreign language to most of the world. Perhaps > something along the lines of "text in most of the world's languages and > scripts" would be a better description. * Micro-blog: Add tests for different languages Feedback from @SaschaMann exercism#1509 (comment) > I think it would be nice to add some test cases that aren't emoji or > English - perhaps cases with germanic umlauts, cyrillic and/or greek > letters, historic scripts etc. - because that's one of the main uses > and goals of unicode. I've added German, Bulgarian, and Greek examples. All of them have non-English characters. None of these characters use multiple UTF-16 codepoints. As such, if you use a UTF-8 programming language you may first have trouble with the German example, but if you use a UTF-16 language you will probably first have trouble at the Emoji example. I chose not to add an example with historic scripts, because I'm not aware of any that display nicely in my terminal or text-editor. Perhaps in future some could be added. I wanted another example that would be problematic in UTF-16, so I added a poker hand example using playing cards. * Micro-blog: Add German truncated example Comically, it goes from "bear carpet" to "beards". @SaschaMann, thank you for finding the example for me: exercism#1509 (comment) * Micro-blog: Add longer maths example Empty set is a proper subset of the natural numbers which is a proper subset of the integers, which is a proper subset of the rational numbers which is a proper subset of the reals which is a proper subset of the complex numbers. It remains true when truncated which is quite nice * paasio: Title as "PaaS I/O" instead of default "Paasio" (exercism#1589) Improves the copy only, so acceptable in light of exercism#1560. * Fix broken link to website contributing document * topics: add 'pointers' in section 'data types' * robot-name description: singular "robot" Use singular forms consistently throughout robot-name/description.md * connect: Replaced rhombus with parallelogram Replaced "rhombus" with "parallelogram" to clarify that the game's board height and width must not be the same. Closes exercism#1597 * minesweeper: remove border (exercism#1602) * minesweeper: remove border Updates the board example to remove the need for a border that doesn't match the test data and clarifies a couple small points. * minesweeper: fix characters Mispelled "asterisk" and didn't use the same character as `diamond` for the blank spaces. * minesweeper: use mine counts Updates "score totals" -> "mine counts". * list-ops: change order in append test case description (exercism#1611) * Change order in append test case description * Bump patch number * isbin-verifier: add EOF newline (exercism#1616) This fix the issue that `configlet generate .` is not idempotent as the track's README might manually adjust for the newline instead. This is something I came across while working on exercism/julia#161. * exercism#1623 `grade-school` canonical data does not correspond to the exercise description (exercism#1624) - case description is altered according to the discussion results - patch version of the canonical-data is updated * fix: Remove trailing spaces I have confirmed that no JSON version change is needed * Bob: Cleans up language on a couple of test cases Resolves exercism#1630 * Bob: Replaces DMV with dentist (exercism#1632) Resolves exercism#1630 Replaces ambiguous `DMV` with `dentist` and `NASA`. Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * luhn: check a number with an even remainder (exercism#1635) * test(luhn): check a long number with an even remainder * fix(luhn): minor version bump instead of a patch * [two-bucket] Make valid moves clearer (exercism#1644) There has been confusion over the reuse of the word "one" in both the descriptions of the bucket ("Bucket one") and the moves ("Move from one bucket"). This removes that confusion, which will help reduce misunderstanding, especially amongst non-native English speakers. * scale-generator: fix name of augmented interval (exercism#1643) The interval described is an augmented *second*, not an augmented first. Added also its composition in terms of steps for completeness. Fixes exercism#1642 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com> * Add requirements of the exercise (exercism#1645) * two-fer: Update description.md (exercism#1583) * Update description.md I don't think it's great anyways but I'm tired of seeing students submit X as the variable name because of picking up some subliminal hint here. * Update exercises/two-fer/description.md Co-Authored-By: Victor Goff <keeperotphones@gmail.com> Co-authored-by: Victor Goff <keeperotphones@gmail.com> * Update Simple Linked List metadata (exercism#1648) Previous link was no longer working properly, so use web.archive.org need this before merging exercism/rust#935 * Fix metadata source_url for simple-linked-list exercise (exercism#1649) Previous web.archive.org link pointed to the book homepage. Change it to point to simple-linked-list page. * Fix apophenia error slowing student progress (exercism#1650) * Fix apophenia error slowing student progress apophenia - noun "the tendency to perceive a connection or meaningful pattern between unrelated or random things" compare: pareidolia - noun "to perceive a specific, often meaningful image in a random or ambiguous visual pattern" - Merriam Webster's * Fix premature doubling in 1st example for Luhn * Update description.md (exercism#1653) The test suite is testing against the key having only lowercase letters, not alphanumeric. * two tests to check case insensitive behavior (exercism#1658) * Revert "two tests to check case insensitive behavior (exercism#1658)" (exercism#1659) This reverts commit ea9db9b. * Palindrome Products: refine the problem (exercism#1662) For me it took a while to understand that we calculate product of exactly two numbers. BTW in the [original problem](https://projecteuler.net/problem=4) it is stated clearly. * robot-name: remove dead link (exercism#1663) gSchool.it is now a domain parking spot * Add uuid field to all test cases (exercism#1676) * Add uuid field to documentation * Update canonical schema * Add uuid field to test cases * Update canonical-schema.json Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * Update comments in README * Remove version check Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * Remove version (exercism#1678) * Replace optional key with scenarios (exercism#1677) * Replace optional key with scenarios Co-authored-by: Victor Goff <keeperotphones@gmail.com> * Add GH Actions CI workflow (exercism#1680) * Add GH Actions CI workflow * install yarn dependencies * fix node-version field * Remove check_optional Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * cache yarn dependencies * use node 12 * remove Travis CI config * Update .github/workflows/ci.yml Co-authored-by: Sascha Mann <git@mail.saschamann.eu> Co-authored-by: Jeremy Walker <jez.walker@gmail.com> Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * Add description of tests.toml (exercism#1682) * Add description of tests.toml * Update CONTRIBUTING.md Co-authored-by: Jeremy Walker <jez.walker@gmail.com> Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Add scenarios to example and describe purpose (exercism#1683) * CI: Clean up workflow and clarify what "JS tests" are (exercism#1697) * Move required files check to separate job * Clarify what JS tests are * Rename schema-tests to schema-validation * CI: Add codeowners (exercism#1699) * CI: Add codeowners * Update .github/CODEOWNERS Co-authored-by: Jeremy Walker <jez.walker@gmail.com> Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Add reimplements to schema (exercism#1703) * Add reimplements to schema * Fix formatting * list-ops: add append case (exercism#1612) * Add case to append empty list to list * Add UUID Co-authored-by: wolf99 <wol99@users.noreply.github.com> * resistor-color/resistor-color-duo: extend exercise explanation (partial copy from resistor-color-duo) (exercism#1667) * CI: Check that UUIDs are unique (exercism#1700) * diffie-hellman: Reword 'in range 1 .. p' (exercism#1688) There are some languages where the syntax `1 .. p` includes both the endpoints. For example, the Nim code: ``` for i in 1 .. 3: echo i ``` shows the output: ``` 1 2 3 ``` So let's prefer the wording from the `description.md`: "Alice picks a private key, a, greater than 1 and less than p." * run-length-encoding: 'lower case' -> 'lowercase' (exercism#1708) This makes it more consistent with another test: "description": "lowercase characters", Both forms are correct, but "lowercase" is more common. See: https://english.stackexchange.com/questions/59409 * isbn-verifier: 'isbn number' -> 'isbn' (exercism#1690) Most of the test descriptions just used 'isbn', so let's be consistent and avoid "International Standard Book Number number". * perfect-numbers: 'natural number' -> 'positive integer' (exercism#1691) There is no convention whether zero is a natural number, so let's avoid the issue. For example, see: - https://mathworld.wolfram.com/NaturalNumber.html - https://en.wikipedia.org/wiki/Natural_number - https://math.stackexchange.com/questions/283/is-0-a-natural-number The previous wording of ``` "description": "Zero is rejected (not a natural number)", ``` could be especially jarring for some tracks. For example, Nim defines `Natural` and `Positive` types, and `Natural` includes 0. See: - https://nim-lang.github.io/Nim/system.html#Natural Co-authored-by: Sascha Mann <git@mail.saschamann.eu> Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * grains: Be more verbose in test-level descriptions (exercism#1707) The top-level `description` of these cases was: ``` "description": "returns the number of grains on the square", ``` but each test-level `description` contained only a number. The comments in `tests.toml` are generated only from the test-level `description`, and so the comments there will now be more informative than the previously seen: ``` # 1 "9fbde8de-36b2-49de-baf2-cd42d6f28405" = true # 2 "ee1f30c2-01d8-4298-b25d-c677331b5e6d" = true ``` * Add Style Guide (exercism#1713) * Add Style Guide * Update STYLE-GUIDE.md Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * Update STYLE-GUIDE.md Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * Update STYLE-GUIDE.md Co-authored-by: Ryan Potts <rpottsoh@users.noreply.github.com> * Update STYLE-GUIDE.md Co-authored-by: Sascha Mann <git@mail.saschamann.eu> * Update STYLE-GUIDE.md * Update STYLE-GUIDE.md Co-authored-by: Sascha Mann <git@mail.saschamann.eu> Co-authored-by: Colin Caine <cmcaine@gmail.com> Co-authored-by: Ryan Potts <rpottsoh@users.noreply.github.com> * CI: Add check that reimplemented-values are valid UUIDs (exercism#1702) Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com> * CI: Use jq instead of grep/sed (exercism#1710) * Add esoteric example. (exercism#1717) * Square-Root: Add new exercise (exercism#1582) * Add square root exercie * Cite myself in metadata * Add radicand explantion, use PR as source_url * Add UUIDs, remove version * Adjust description.md Co-authored-by: wolf99 <wol99@users.noreply.github.com> * CI: Add workflow_dispatch as manual trigger (exercism#1711) This is useful for debugging CI or when working on a branch before opening a PR * security: CVE-2020-7598 (exercism#1706) * ⬆️ latest ajv-cli * 🔒 CVE-2020-7598 * Add abbreviations and restructure slightly (exercism#1718) * Add abbreviations and restructure slightly * Update STYLE-GUIDE.md * Update with better text * Update STYLE-GUIDE.md Co-authored-by: Colin Caine <cmcaine@gmail.com> * Update STYLE-GUIDE.md Co-authored-by: Colin Caine <cmcaine@gmail.com> Co-authored-by: Derk-Jan Karrenbeld <derk-jan@karrenbeld.info> * Style: Fix whitespace issues (exercism#1720) * Style: Remove trailing whitespace With this commit, people who run `configlet generate` and commit the generated READMEs as-is will no longer introduce trailing whitespace into their track repos. * Style: Add missing final newlines * grade-school: Fix typo in test description (exercism#1689) * queen-attack: Fix typo in test description (exercism#1692) * Update nucleotide-count description (exercism#1719) See also exercism#1716. Thanks to SleeplessByte, rpottsoh, kotp, ErikSchierboom, etc :) * CI: Add /rebase command (exercism#1698) (stolen from v3 repo) * Add workflow recommendations and templates (exercism#1722) Adds a document that explains how to set up Continuous Integration (CI) workflows for an Exercism Language Track using GitHub Actions (GHA). It provides best practices and examples for you to use to make your own fast, reliable and robust CI workflows. Additionally, it provides GHA workflows. The GHA workflows can be adapted to work with any CI, track, or project, because the base structure will remain the same. * CI: Ensure immutability of test cases (exercism#1712) * CI: Check immutability of test data * Iterate old cases instead * Add to ci.yml workflow * Fix path to python script in workflow * Set chmod=+x for python script * Apparently latest does not mean latest * Fix path * Test mutated test in PR * Revert "Test mutated test in PR" This reverts commit 18dbfa2. * Fix build for workflow_dispatch triggers * Break out of loop early on failure * Fix typo * Handle removal of tests better * Add scenarios check * Update bin/check-immutability.py * Make variable names longer & use sys.exit instead of exit Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Corey McCandless <cmccandless@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Corey McCandless <cmccandless@users.noreply.github.com> * Add test data for future edits to the script Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Corey McCandless <cmccandless@users.noreply.github.com> * rational-numbers: Make formulas more readable (exercism#1655) * rational-numbers: Make formulas more readable * Remove superscript characters * Readd parentheses * leap: fix typo (exercism#1726) * rational-numbers: Remove redundant factor (exercism#1727) If `b₁ = 0`, then `r₁` is not a rational number anyway. From https://github.com/exercism/problem-specifications/pull/1655/files#r421573667 * two-bucket: test inability to reach the goal (exercism#1580) 1. A test where the goal is too large. The student solution would need to either: * (If searching the state space) Notice that there are no further states to be visited, and yet the solution has not been reached. * Notice that the goal is larger than the larger bucket, therefore can be rejected immediately. 2. A test where the goal is not too large yet still can't be reached The student solution would need to either: * (If searching the state space) Notice that there are no further states to be visited, and yet the solution has not been reached. * Notice that the goal is not divisible by the GCD of the bucket sizes, therefore can be rejected immediately. In case the student assumes that all non-coprime bucket counts will invalidate the goal, a counterexample to that is given as well (buckets not coprime but goal is still possible). There are ten implementing tracks: bash csharp fsharp go java javascript python ruby rust typescript Of these tracks, only two of them (Bash, Go) currently test the condition where it is not possible to reach the goal. Having this test serves as a reminder that it remains wise to handle the situation where a search has not found its goal. It doesn't seem like this was discussed in the original submission: exercism/DEPRECATED.javascript#68 So it seems like it would be good to have a discussion of it on record. * [CI] Bump rebase action to fix CVE-2020-15228 (exercism#1731) * [CI] Only run immutability check on PRs (exercism#1730) Let's remove this until exercism#1728 has been resolved properly to avoid build errors on master. * Remove linkless words (exercism#1733) * build(deps): bump ini from 1.3.5 to 1.3.7 (exercism#1734) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Grade school exercise: A student cannot simultaneously be in two grades since the users' names are unique (exercism#1735) * Add configlet (exercism#1737) * change: add simplest test case (exercism#1739) * prime-factors: add further variations (exercism#1755) * [transpose] added 'jagged triangle' test (exercism#1748) * kindergarten-garden: completionist (exercism#1744) * list-ops: reimplement ambiguous tests (exercism#1746) * Format * Re-implement ambigious test cases * Clarifying comment * Re-add old versions of reimplemented tests * Remove accidantally commited executable * Clarifying commentary about integer division. * Add advice * Hamming: remove tests that don't make sense per 1761 (exercism#1762) * Hamming: remove tests that dont make sense * return tests & normalise error messages * grade-school: Change a UUID to be version 4 (exercism#1760) Commit 03529d0 (exercism#1735) added a new test case for the `grade-school` exercise, but the UUID added was version 1 rather than version 4. This was not caught by CI because the regex in the schema validator was too permissive (fixed by exercism#1759). Some reasons to prefer version 4 UUIDs: - Version 4 is the right version for a fully random and unique identifer; we don't want to indicate anything about the machine that generated the UUID, and version 1 UUIDs have a timestamp and MAC address component. - All of the other UUIDs currently in `problem-specifications` are valid version 4 UUIDs. - `configlet uuid` generates a version 4 UUID. - A reader familiar with the UUID specification (RFC 4122) might see a version 1 UUID and infer that the timestamp or MAC address component is useful, causing them to wonder why the others are version 4. - A user who generates a version 1 UUID might unintentionally leak their MAC address. See also: - https://tools.ietf.org/html/rfc4122.html * canonical-schema: Fix UUID regex pattern (exercism#1759) Commit cea02af (exercism#1676) added a UUID to each test case. However, the regex pattern that it added to the canonical schema was too permissive, meaning that CI would pass on a PR that added, for example, a version 1 UUID (see exercism#1735). Changes: - Use `a-f` instead of `a-z` - The third group must start with `4`. - The fourth group must start with `8`, `9`, `a` or `b`. * [CI] Verify that scenarios are defined in schema Co-authored-by: Josh Goebel <me@joshgoebel.com> Co-authored-by: Victor Goff <keeperotphones@gmail.com> Co-authored-by: Victor Goff <keeperotphones+github@gmail.com> Co-authored-by: Katrina Owen <kytrinyx@github.com> Co-authored-by: wolf99 <wolf99@users.noreply.github.com> Co-authored-by: DagmarTimmreck <dagmar.timmreck@actano.de> Co-authored-by: Michael Morehouse <640167+yawpitch@users.noreply.github.com> Co-authored-by: Peter Tseng <petertseng@users.noreply.github.com> Co-authored-by: Chris Couzens <ccouzens@gmail.com> Co-authored-by: Sam Warner <sam.warner@blackpepper.co.uk> Co-authored-by: Gabriel Nelle <tehsphinx@web.de> Co-authored-by: Chris White <cxwembedded@gmail.com> Co-authored-by: traxam <tr808axm@gmail.com> Co-authored-by: ShaoWei Teo <tookunokaze@gmail.com> Co-authored-by: Elena Parovyshnaia <elena.parovyshnaya@gmail.com> Co-authored-by: Florian Keller <github@floriankeller.de> Co-authored-by: Ryan Potts <rpottsoh@users.noreply.github.com> Co-authored-by: Ryan Potts <rpottsoh@gmail.com> Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> Co-authored-by: Pranas Ziaukas <pranas.ziaukas@gmail.com> Co-authored-by: Jeremy Walker <jez.walker@gmail.com> Co-authored-by: Rafael F <r4f4rfs@gmail.com> Co-authored-by: Zuzanna Kru <zuzia.kru@gmail.com> Co-authored-by: Bruce Park <treble37@users.noreply.github.com> Co-authored-by: Tejas Bubane <tejasbubane@gmail.com> Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com> Co-authored-by: Charles Ross <chivalry@mac.com> Co-authored-by: Ole Kröger <o.kroeger@opensourc.es> Co-authored-by: DmitrySamoylov <56959852+DmitrySamoylov@users.noreply.github.com> Co-authored-by: Colin Caine <cmcaine@gmail.com> Co-authored-by: Sascha Mann <git@mail.saschamann.eu> Co-authored-by: Corey McCandless <cmccandless@users.noreply.github.com> Co-authored-by: wolf99 <281700+wolf99@users.noreply.github.com> Co-authored-by: wolf99 <wol99@users.noreply.github.com> Co-authored-by: Kirill Artamonov <artamonov.kirill@gmail.com> Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com> Co-authored-by: Derk-Jan Karrenbeld <derk-jan@karrenbeld.info> Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Yunseon Choi <science_co@naver.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pedro Rolo <pedrorolo@gmail.com> Co-authored-by: peerreynders <17050883+peerreynders@users.noreply.github.com>

coriolinus approved these changes May 5, 2020

View reviewed changes

kotp added the hold label May 5, 2020

yawpitch requested changes May 7, 2020

View reviewed changes

SaschaMann commented May 7, 2020

View reviewed changes

exercises/rational-numbers/description.md Outdated Show resolved Hide resolved

exercises/rational-numbers/description.md Outdated Show resolved Hide resolved

exercises/rational-numbers/description.md Outdated Show resolved Hide resolved

SaschaMann commented May 7, 2020

View reviewed changes

SaschaMann added 3 commits October 13, 2020 16:25

rational-numbers: Make formulas more readable

c609e73

Remove superscript characters

cf3c70e

Readd parentheses

d7c29d5

SaschaMann force-pushed the more-readable-maths branch from 880ea33 to d7c29d5 Compare October 13, 2020 14:25

kotp removed the hold label Oct 13, 2020

iHiD merged commit b889bf8 into master Oct 28, 2020

iHiD deleted the more-readable-maths branch October 28, 2020 23:04

SaschaMann mentioned this pull request Jun 14, 2021

pythagorean-triplets: Fix maths notation in instructions #1808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rational-numbers: Make formulas more readable #1655

rational-numbers: Make formulas more readable #1655

SaschaMann commented May 4, 2020 •

edited

Loading

coriolinus commented May 4, 2020 •

edited

Loading

SaschaMann commented May 4, 2020 •

edited

Loading

rpottsoh commented May 5, 2020 •

edited

Loading

kotp commented May 5, 2020

coriolinus commented May 5, 2020

SaschaMann commented May 5, 2020

coriolinus left a comment

kotp commented May 5, 2020

yawpitch left a comment

rpottsoh commented May 7, 2020

SaschaMann commented May 7, 2020

SaschaMann May 7, 2020

iHiD commented May 7, 2020

coriolinus commented May 7, 2020

iHiD commented May 7, 2020

SaschaMann commented May 7, 2020 •

edited

Loading

iHiD commented May 7, 2020

yawpitch commented May 8, 2020 •

edited

Loading

SaschaMann commented Oct 13, 2020

iHiD commented Oct 13, 2020

SaschaMann commented Oct 28, 2020

iHiD commented Oct 28, 2020


		Dividing a rational number `r1 = a1/b1` by another `r2 = a2/b2` is `r1 / r2 = (a1 * b2) / (a2 * b1)` if `a2 * b1` is not zero.
		Dividing a rational number `r₁ = a₁/b₁` by another `r₂ = a₂/b₂` is `r₁ / r₂ = (a₁ * b₂) / (a₂ * b₁)` if `a₂ * b₁` is not zero.

rational-numbers: Make formulas more readable #1655

rational-numbers: Make formulas more readable #1655

Conversation

SaschaMann commented May 4, 2020 • edited Loading

coriolinus commented May 4, 2020 • edited Loading

SaschaMann commented May 4, 2020 • edited Loading

rpottsoh commented May 5, 2020 • edited Loading

kotp commented May 5, 2020

coriolinus commented May 5, 2020

SaschaMann commented May 5, 2020

coriolinus left a comment

Choose a reason for hiding this comment

kotp commented May 5, 2020

yawpitch left a comment

Choose a reason for hiding this comment

rpottsoh commented May 7, 2020

SaschaMann commented May 7, 2020

SaschaMann May 7, 2020

Choose a reason for hiding this comment

iHiD commented May 7, 2020

coriolinus commented May 7, 2020

iHiD commented May 7, 2020

SaschaMann commented May 7, 2020 • edited Loading

iHiD commented May 7, 2020

yawpitch commented May 8, 2020 • edited Loading

SaschaMann commented Oct 13, 2020

iHiD commented Oct 13, 2020

SaschaMann commented Oct 28, 2020

iHiD commented Oct 28, 2020

SaschaMann commented May 4, 2020 •

edited

Loading

coriolinus commented May 4, 2020 •

edited

Loading

SaschaMann commented May 4, 2020 •

edited

Loading

rpottsoh commented May 5, 2020 •

edited

Loading

SaschaMann commented May 7, 2020 •

edited

Loading

yawpitch commented May 8, 2020 •

edited

Loading