largest-series-product corner cases #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Interesting that the CI is failing. The flake failures are files untouched by me. I ran tests locally and this worked, so I know this exercise is fine. But something changed in the past 16 days. Maybe flake added new tests? |
Member
Author
|
Seems unlikely. flake8 hasn't changed either at https://gitlab.com/pycqa/flake8/commits/master . So I am stumped. |
Member
Author
|
Tested an empty commit on master. That also fails. Guess we gotta get those fixed up. I really do wonder what changed... E: Ah. The combination of flake8 forbidding 1.6 but pep8 releasing 1.7 means that now flake8 is now checking things it wasn't checking before. Guess we just have to comply with new rules now. |
The original tests had tests for "" and 0. This is when both inputs are the boundary condition. Now we should also test when only one input is at the boundary. So we should test a non-empty string with 0, and "" with a nonzero span. These are consistent with the values defined in https://github.com/exercism/x-common/blob/master/largest-series-product.json
In these cases, the result should be 0 as well. This guards against solutions that assume the minimum is 1.
Member
Author
|
Rebased on master. Should be fine now. |
behrtam
added a commit
that referenced
this pull request
Jan 26, 2016
largest-series-product corner cases
Contributor
|
Looks good. Thanks for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work to have consistency between tracks as in https://github.com/exercism/todo/issues/104 and https://github.com/exercism/todo/issues/13. Comments are in individual commit messages.