Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Largest Series Product] Synchronize Addendum Example Code with Tests #3388

Merged
merged 1 commit into from Apr 12, 2023

Conversation

MatthijsBlom
Copy link
Contributor

This patch assumes that the intent of this instructions.append.md was to match the actual requirements.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Apr 6, 2023
@BethanyG BethanyG reopened this Apr 6, 2023
@BethanyG
Copy link
Member

BethanyG commented Apr 6, 2023

Leaving a note here: exercism/problem-specifications#2246 is discussing the removal of the tests. Once it is PR'd to the tracks, this PR will need to be adjusted/amended.

We'll need to adjust the JinJa2 template, regenerate the test files, and then re-edit this addendum accordingly.

Meanwhile, I am going to put this on hold until the upstream changes are completed.

Edited to add: The upstream changes have been merged, and Katrina will be PR-ing track changes next week, so we should revisit this then.

@BethanyG BethanyG added the on hold ✋🏽 Action should stop on this issue or PR for now. label Apr 6, 2023
@BethanyG BethanyG changed the title Synchronize example code with tests [Largest Series Product] Synchronize Addendum Example Code with Tests Apr 6, 2023
@BethanyG BethanyG removed the on hold ✋🏽 Action should stop on this issue or PR for now. label Apr 12, 2023
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty. Now that we have things sorted with the intro and which tests are included, we can merge this! Thank you for submitting it. 😄

@BethanyG BethanyG merged commit 17d4f7b into exercism:main Apr 12, 2023
15 checks passed
@MatthijsBlom MatthijsBlom deleted the patch-1 branch May 26, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants