Add acronym exercise #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Awesome, thank you so much :-) It runs fine for me, also while refactoring the example to a magrittr pipeline. |
| "slug": "acronym", | ||
| "uuid": "54e60174-4833-418c-b9af-2fcb5722b1d6", | ||
| "core": false, | ||
| "unlocked_by": null, |
There was a problem hiding this comment.
Do you consider it the simplest strings or filtering exercise? If so, should we let a similar one be unlocked by this?
There was a problem hiding this comment.
Let's do this in another PR: We have a few more "floating" exercises that we could attach somewhere.
|
Awesome, thank you so much :-) It runs fine for me, also while refactoring the example to a magrittr pipeline. |
|
Thanks for this PR @zacchaeusluke! |
katrinleinweber
approved these changes
Sep 4, 2018
| "slug": "acronym", | ||
| "uuid": "54e60174-4833-418c-b9af-2fcb5722b1d6", | ||
| "core": false, | ||
| "unlocked_by": null, |
There was a problem hiding this comment.
Let's do this in another PR: We have a few more "floating" exercises that we could attach somewhere.
|
Thank you @zacchaeusluke :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ported the acronym exercise