New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update explanation of floating point numbers for Ruby Assembly Line exercise #1485
Conversation
…s better A floating point number has at least one number after the decimal point, not zero or more. This explanation conflicts with the integers explanation which states its "numbers with no digits behind the decimal separator".
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
@tekwizz123 I clicked on the "this link" and made the new topic here. |
Verifying that here (I didn't actually know if
|
It is not, it is really not
So it is a bit tricky, as what we think we are seeing as a number |
Excellent. Thanks for clarifying. This explains why my brain had no record for |
Let's expand this to be better in whole, since the Integer description talks about some digits behind the decimal point, but there is no decimal point in an Integer. Also, the commit message is not quite in compliance with git recommendations. The commit summary is at a length of 77, when it should be less than 50¹ . This will cause some problems with the GUI tools with displaying, and the subject line of the e-mail message for this patch being that long is problematic as well. See the git-scm discussion section on commit for more information., or if you prefer not to go out to the web, you can see the DISCUSSION section from |
@kotp what is the status of this PR? It looks like it has been approved, but it's not merged. Is there a reason why it's being held further? |
In terms of me not lighting the fire, was hoping @tekwizz123 would confirm. But it has been long enough. And things are noted, so it surely can come in. |
A floating point number has at least one number after the decimal point, not zero or more.
This explanation conflicts with the integers explanation which states its "numbers with no digits behind the decimal separator".