Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explanation of floating point numbers for Ruby Assembly Line exercise #1485

Merged
merged 1 commit into from Mar 11, 2023

Conversation

tekwizz123
Copy link
Contributor

A floating point number has at least one number after the decimal point, not zero or more.

This explanation conflicts with the integers explanation which states its "numbers with no digits behind the decimal separator".

…s better

A floating point number has at least one number after the decimal point, not zero or more.

This explanation conflicts with the integers explanation which states its "numbers with no digits behind the decimal separator".
@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 16, 2023
@tekwizz123 tekwizz123 changed the title Update explanation of floating point numbers Update explanation of floating point numbers for Ruby Assembly Line exercise Jan 16, 2023
@kotp
Copy link
Member

kotp commented Jan 17, 2023

@tekwizz123 I clicked on the "this link" and made the new topic here.

@kotp kotp reopened this Jan 17, 2023
@iHiD
Copy link
Member

iHiD commented Jan 17, 2023

Verifying that here (I didn't actually know if 5. was an Integer or a Float:

irb(main):010:0> (5. + 3).class
=> Integer
irb(main):011:0> (5.0 + 3).class
=> Float

@iHiD iHiD self-requested a review January 17, 2023 13:10
@kotp
Copy link
Member

kotp commented Jan 17, 2023

Verifying that here (I didn't actually know if 5. was an Integer or a Float:

irb(main):010:0> (5. + 3).class
=> Integer
irb(main):011:0> (5.0 + 3).class
=> Float

It is not, it is really not 5. since the . is really attached to the +. As we can see here:

>> 5.+(3)
=> 8

So it is a bit tricky, as what we think we are seeing as a number 5. it is only the 5 that is the number.

@iHiD
Copy link
Member

iHiD commented Jan 17, 2023

Excellent. Thanks for clarifying. This explains why my brain had no record for 5. syntax! 😁

@kotp
Copy link
Member

kotp commented Jan 17, 2023

Let's expand this to be better in whole, since the Integer description talks about some digits behind the decimal point, but there is no decimal point in an Integer.

Also, the commit message is not quite in compliance with git recommendations. The commit summary is at a length of 77, when it should be less than 50¹ . This will cause some problems with the GUI tools with displaying, and the subject line of the e-mail message for this patch being that long is problematic as well.

See the git-scm discussion section on commit for more information., or if you prefer not to go out to the web, you can see the DISCUSSION section from man git-commit for the same information.

@kytrinyx
Copy link
Member

@kotp what is the status of this PR? It looks like it has been approved, but it's not merged. Is there a reason why it's being held further?

@kotp
Copy link
Member

kotp commented Mar 11, 2023

In terms of me not lighting the fire, was hoping @tekwizz123 would confirm. But it has been long enough. And things are noted, so it surely can come in.

@kotp kotp merged commit cd4360b into exercism:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants