Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-square: Reflect changes to problem specifications #738

Merged
merged 5 commits into from Oct 22, 2017

Conversation

@nholden
Copy link
Contributor

@nholden nholden commented Oct 15, 2017

Why?

We recently made some changes to the crypto-square exercise over in exercism/problem-specifications to stop testing intermediate functions, fix inconsistencies in the description, and generally improve tests.

Bringing our tests and README inline with the new specifications would address #422, #545. Using a generator to do so would help us with our goal of generating all exercise tests.

What?

This PR:

  • Adds a test generator for crypto-square
  • Generates tests for crypto-square from the canonical data
  • Updates the example solution to reflect the changes to the specification
  • Updates the README to reflect changes to the specification

How Has This Been Tested?

I ran the updated example solution against the newly generated tests and they passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or enhancement that would cause existing functionality to change)
  • Gardening (code and/or documentation cleanup)

References and Closures

Closes #422 and #545.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change relies on a pending issue/pull request
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@nholden nholden mentioned this pull request Oct 16, 2017
3 of 10 tasks complete
@Insti
Copy link
Contributor

@Insti Insti commented Oct 17, 2017

This looks great, thanks @nholden I'll have a closer look at it when I can find some time in the next day or so.

@nholden
Copy link
Contributor Author

@nholden nholden commented Oct 20, 2017

Just a heads up: I'll be off the grid for a bit, so if there are any requested changes to this PR, feel free to go ahead and make them without me if you'd like, or I'll be happy to loop back in early November.

@Insti Insti merged commit e33dae1 into exercism:master Oct 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Insti
Copy link
Contributor

@Insti Insti commented Oct 22, 2017

Thanks @nholden ❤️

@nholden nholden deleted the nholden:crypto-square-generator branch Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.