Skip to content

series: expected result values for too long and zero length tests appear swapped #439

@tjkierzkowski

Description

@tjkierzkowski

I noticed that the tests used in the series exercise to validate if the series function is too long and the test for if the series function has a zero length appear to be incorrect. For instance, the test test_with_zero_length should likely have an expected value of vec![""] instead of a Vector with _len number of empty strings (see this line). I wrote and submitted the code to make the current tests pass but it seems like the expected cases may have been swapped by mistake. I can imagine this would break a quite a few people's exercism submissions for this exercise (roughly 141 as of this comment). I wanted to reach out on what to do with this or to get some clarification on if this is an issue. I'm not sure this test is broken in other language tracks version of the series exercise. The Python tests throw a ValueError exception and I haven't looked at others just yet. The fix would be simple and I'm willing to submit a pull request for this. Thanks for curating this track!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions