-
Notifications
You must be signed in to change notification settings - Fork 163
[C#] Add concepts for protein-translation exercise #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great! One small suggestion: maybe also add a link to the actual exercise in the v2 csharp repository?
Maybe we should also be listing different approaches (if there are any). Like https://github.com/exercism/v3/pull/234/files does. But I'm not entirely sure other approaches are common. Maybe one could use a dictionary or an if-statement instead of the switch? And it might also be possible to use LINQ here (TakeWhile).
languages/csharp/reference/exercise-concepts/protein-translation.md
Outdated
Show resolved
Hide resolved
languages/csharp/reference/exercise-concepts/protein-translation.md
Outdated
Show resolved
Hide resolved
Thanks for the review! Regarding this:
Good idea regarding the dictionary vs switch statement approach. Regarding the |
I'm not sure. Let's ignore this. |
/rebase |
e9e9601
to
8cf2fc9
Compare
/rebase |
…on.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com>
…on.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com>
8cf2fc9
to
0ddc60a
Compare
Solves #264
There turned out to be more concepts than what I was originally imagining for such a straight-forward exercise. Let me know if any of the concepts are too fine grained.