Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[C#] Add concepts for protein-translation exercise #265

Merged
merged 4 commits into from
Jan 29, 2020

Conversation

robkeim
Copy link
Contributor

@robkeim robkeim commented Jan 22, 2020

Solves #264

There turned out to be more concepts than what I was originally imagining for such a straight-forward exercise. Let me know if any of the concepts are too fine grained.

@robkeim robkeim requested a review from a team January 22, 2020 21:35
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great! One small suggestion: maybe also add a link to the actual exercise in the v2 csharp repository?

Maybe we should also be listing different approaches (if there are any). Like https://github.com/exercism/v3/pull/234/files does. But I'm not entirely sure other approaches are common. Maybe one could use a dictionary or an if-statement instead of the switch? And it might also be possible to use LINQ here (TakeWhile).

@robkeim
Copy link
Contributor Author

robkeim commented Jan 24, 2020

Thanks for the review! Regarding this:

Maybe we should also be listing different approaches (if there are any). Like https://github.com/exercism/v3/pull/234/files does. But I'm not entirely sure other approaches are common. Maybe one could use a dictionary or an if-statement instead of the switch? And it might also be possible to use LINQ here (TakeWhile).

Good idea regarding the dictionary vs switch statement approach. Regarding the TakeWhile approach, how exactly were you thinking of using it?

@ErikSchierboom
Copy link
Member

Regarding the TakeWhile approach, how exactly were you thinking of using it?

I'm not sure. Let's ignore this.

@ErikSchierboom
Copy link
Member

/rebase

@ErikSchierboom
Copy link
Member

/rebase

@iHiD iHiD merged commit ff0e035 into master Jan 29, 2020
@iHiD iHiD deleted the csharp/protein-translation branch January 29, 2020 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants