Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ruby/HighScores: New Notes Format #633
Here's Mentor Notes with a different format.
It's meant to make mentoring easier for mentors, and also improve consistency of mentoring.
Note on the new 'Minimal Solution for Approval' : this is meant for the easiest exercises only, where there's only one, maybe two idiomatic solutions. That goes for only a few exercises. In Ruby: TwoFer, Acronym, HighScores.
I'm a fan of this change, given that my own PR's actually have the "concepts" and "variations" sections.
That said, I don't like the "only have minimal solutions for simple exercises". Either have it or don't. I think "reasonable solutions" with "accepted variations" is more vague and in this case better than steering towards a minimal solution.
Many mentors are IMO too rigid when it comes to accept non-note-reasonable-solutions and using the "this is right" type of notes only encourages that type of behaviour.
Strictly speaking not as far as I can see. Personally would prefer not to abbreviate words because of the multiple reasons that abbreviations end up being a little harder for non-native speakers. The words being used in that way are likely known from a "I am programmer" land though.
A little bit stronger objection would be "standard library" vs "core library" since for Ruby there is a difference, and core is more the focus than the standard library. (see this review comment).
Thanks @F3PiX, there is no rush. It just was not clear to me what the hold up was since there were two approvals. I'm happy to merge this if you like, but I tend not to merge if the issuer has write access (or an excessive amount of time has transpired and the PR appears to be OK to merge).