Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
csharp/leap: Improve mentor notes #640
This is matching the other tracks where exercises are being disapproved if they don't match the order of the instructions due to the redundancy of tests.
I've been mentored here that I could leave out parentheses which I didn't like as it is logically not the same solution; other students following multiple tracks might actually get confused if one track enforces this (JS
Personally I think the exercise was chosen, originally for the ruby track, exactly because it's simple to implement but has a lot of haken en ogen.
I can't use GitHub formatting in email response, but the second comment
The instructions are as follows +paraphrased+
A year is a leap year if it is divisible by 4 AND
The inverse test or lacking parentheses yield different "resulting instructions". This sets up the student to read the instructions carefully.
After some thought, I'll approve this. It's up to the mentor to determine if the student could benefit from pointing out the execution order problem.