Skip to content

/ website

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile Update: Add conditional db seeding to `init.dev.sh` #182

Merged
merged 5 commits into from Oct 9, 2020
Merged

Dockerfile Update: Add conditional db seeding to `init.dev.sh` #182

merged 5 commits into from Oct 9, 2020

Conversation

@neenjaw
Copy link
Collaborator

@neenjaw neenjaw commented Oct 8, 2020

Close #180
@neenjaw
Add conditional db seeding to `init.dev.sh`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a6f9402
@neenjaw neenjaw requested a review from iHiD as a code owner Oct 8, 2020
@iHiD iHiD requested a review from ErikSchierboom Oct 8, 2020
@iHiD
iHiD approved these changes Oct 8, 2020
View changes
@iHiD
Copy link
Member

@iHiD iHiD commented Oct 8, 2020

@ErikSchierboom One for you 🙂
@iHiD
iHiD reviewed Oct 8, 2020
View changes
docker/dev/init.dev.sh Outdated Show resolved Hide resolved
@neenjaw @iHiD
Update docker/dev/init.dev.sh
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c02776 
Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
@neenjaw neenjaw marked this pull request as draft Oct 8, 2020
@neenjaw
neenjaw reviewed Oct 8, 2020
View changes
docker/dev/init.dev.sh Outdated Show resolved Hide resolved
neenjaw added 2 commits Oct 8, 2020
@neenjaw
Update docker/dev/init.dev.sh
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
76d88a1
@neenjaw
Updated
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
63a5581
@neenjaw
Copy link
Collaborator Author

@neenjaw neenjaw commented Oct 9, 2020

Ok, this fix is good, but it is written for bash. The docker init.dev.sh script is being run in the sh shell which doesn't support the same syntax.
@neenjaw
shell script changed for bourne shell
Verified
This commit was signed with a verified signature.
neenjaw Tim Austin
GPG key ID: 5D8C90C8A1CF1FE7 Learn about signing commits
Loading status checks…
2bedba3 
Script was previously written for bourne again shell (bash)
where the docker image calls `init.dev.sh` using `sh` rather than `bash`
So it was failing at the `if` comparison since `[[ ... ]]` only exists
in `bash`.
@neenjaw
Copy link
Collaborator Author

@neenjaw neenjaw commented Oct 9, 2020

It now seems to work as expected locally for me with this last script change.
@neenjaw neenjaw marked this pull request as ready for review Oct 9, 2020
@neenjaw neenjaw requested a review from iHiD Oct 9, 2020
@iHiD
iHiD approved these changes Oct 9, 2020
View changes
@ErikSchierboom
ErikSchierboom approved these changes Oct 9, 2020
View changes
@ErikSchierboom ErikSchierboom merged commit 12a3000 into exercism:master Oct 9, 2020
2 checks passed
2 checks passed
rubocop rubocop
Details
test test
Details
@ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Oct 9, 2020

Thanks @neenjaw!
@neenjaw neenjaw deleted the neenjaw:patch-1 branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom

@iHiD iHiD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

DB not seeding on start
3 participants
@neenjaw @iHiD @ErikSchierboom