Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin mentor page #394

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@loriking
Copy link
Member

loriking commented Sep 7, 2018

Part 1 (issue#28) of issue#33 Build out admin section for mentors

This concerns the creation of a section for administrators of Exercism to get an overview of mentors on the site.
see: https://github.com/exercism/guest-contributors/issues/28
see also: https://github.com/exercism/guest-contributors/issues/33

@iHiD
Copy link
Contributor

iHiD left a comment

Nice work. Couple of minor comments :)

end

# ###### #
# Mentor #
# ###### #
# ###### #,

This comment has been minimized.

@iHiD

iHiD Sep 9, 2018

Contributor

This is breaking the build.

This comment has been minimized.

@loriking

loriking Sep 10, 2018

Author Member

Fixed. Ran the system test file and it appears to be working. I have pushed the changes.

@@ -0,0 +1,3 @@
# Place all the behaviors and hooks related to the matching controller here.

This comment has been minimized.

@iHiD

iHiD Sep 9, 2018

Contributor

Can you delete this empty file pls :)

This comment has been minimized.

@loriking

loriking Sep 10, 2018

Author Member

Removed

@@ -0,0 +1,3 @@
// Place all the styles related to the admin/mentors controller here.

This comment has been minimized.

@iHiD

iHiD Sep 9, 2018

Contributor

Can you delete this one too.

This comment has been minimized.

@loriking

loriking Sep 10, 2018

Author Member

Removed

@@ -0,0 +1,2 @@
module Admin::MentorsHelper

This comment has been minimized.

@iHiD

iHiD Sep 9, 2018

Contributor

And this one.

This comment has been minimized.

@loriking

loriking Sep 10, 2018

Author Member

Removed

@iHiD

This comment has been minimized.

Copy link
Contributor

iHiD commented Sep 10, 2018

@loriking Can you remove the .DS_Store files too pls? Your coaches should be able to explain how to add these to your .gitignore :)

@iHiD

This comment has been minimized.

Copy link
Contributor

iHiD commented Sep 12, 2018

@loriking You'll want to add this to your local gitignore file rather than changing the one in the project as DS_Store files are local to your setup. Instructions are here

@loriking

This comment has been minimized.

Copy link
Member Author

loriking commented Sep 12, 2018

@iHiD Thank you for the clarification and instructions. It's fixed now.

@iHiD

This comment has been minimized.

Copy link
Contributor

iHiD commented Sep 12, 2018

Thanks. Can you remove the commit from this branch pls? You'll want to use an interactive rebase and a force push :)

@loriking loriking force-pushed the loriking:admin_mentor_page branch 2 times, most recently from 175e931 to 955a8ad Sep 13, 2018

@loriking loriking force-pushed the loriking:admin_mentor_page branch from 955a8ad to f668a79 Sep 19, 2018

@iHiD

iHiD approved these changes Sep 20, 2018

@iHiD

This comment has been minimized.

Copy link
Contributor

iHiD commented Sep 20, 2018

Great. Thank you!

@iHiD iHiD merged commit cb97436 into exercism:master Sep 20, 2018

2 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.