Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme: Update default generator example. #595

Merged
merged 1 commit into from May 3, 2017
Merged

Readme: Update default generator example. #595

merged 1 commit into from May 3, 2017

Conversation

Insti
Copy link
Contributor

@Insti Insti commented May 3, 2017

Add some missing elements:
require statement
Generator namespace

@Insti
Update default generator example.
c7c847b 
Add some missing elements:
require statement
`Generator` namespace
@Insti Insti added the ready label May 3, 2017
hilary
hilary approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@hilary hilary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😄

@hilary hilary merged commit ae255c8 into exercism:master May 3, 2017
@Insti Insti deleted the Update_readme branch May 3, 2017 16:43
@Insti
Copy link
Contributor Author

Insti commented May 3, 2017

I was trying to make one, so thought I should read the instructions about how to do it.

@hilary
Copy link
Contributor

hilary commented May 3, 2017

What did you think about the instructions overall?

@Insti Insti removed the ready label May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilary hilary hilary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Insti @hilary