Small change to util:node-by-id to avoid unexpected NPE #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by its nodeId does actually exist within the document or return an empty sequence instead. Not checking may lead to an undesirable NPE as a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util:node-by-idshould be changed to always check if the node identified by its nodeId does actually exist within the document or return an empty sequence instead. Not checking may lead to an undesirable and confusing NPE as a follow up. Instead we want to be able to determine that the node was not found.Fixes the NPE reported here: #3363 (comment)
Type of tests:
Test included.