New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in documentation #2

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Collaborator

paultcochrane commented May 6, 2018

While reading through the README I noticed a couple of typos. These have been fixed in the README and the POD in this PR. If you're not happy with this PR and want something changed, please just let me know and I'll update as appropriate and resubmit.

@exodist

This comment has been minimized.

Owner

exodist commented May 7, 2018

I am pretty short on time to devote to this module. I have added you as a colaberator, go ahead and merge your improvements. If you give me your PAUSE id I will give you upload permissions as well.

@paultcochrane

This comment has been minimized.

Collaborator

paultcochrane commented May 7, 2018

Awesome, thanks! My PAUSE id is "PTC". My guess is that I'll be making mainly cosmetic changes to the dist, so hopefully that's some kind of a help. Is there anything you would like me to consider while making changes? Is there a development style you like/don't like that I should be aware of? I'd like to keep things consistent to your programming style if at all possible.

@exodist

This comment has been minimized.

Owner

exodist commented May 7, 2018

I am not too picky for this module, I have been neglecting it, and it is not at all a priority for me. You now have co-maint on cpan.

@paultcochrane

This comment has been minimized.

Collaborator

paultcochrane commented May 7, 2018

Just as a quick question: would you be able to link this repo to Travis and AppVeyor? Don't know if you have accounts on those services, but if you do, that'd be very helpful for two of the PRs I've got in the pipeline. If it's too much work, don't worry about it, I'll see if I can link things up another way.

@paultcochrane paultcochrane merged commit 4568df2 into exodist:master May 7, 2018

@paultcochrane paultcochrane deleted the paultcochrane:pr/fix-typos-in-docs branch May 7, 2018

@exodist

This comment has been minimized.

Owner

exodist commented May 7, 2018

I went to enable it and it looks like github is deprecating the use of services, do you know what the correct way to add it is now?

@paultcochrane

This comment has been minimized.

Collaborator

paultcochrane commented May 8, 2018

It's been a while since I did it, but I think services aren't needed, and that one just needs to give Travis read access to your GitHub repos. IIRC, one logs in to Travis (the GitHub credentials should work here) and then goes to https://travis-ci.org/profile/ where you can then sync your repos. You should get asked at some point by GitHub if Travis should be allowed access to your repos, and once accepted, the sync process should "just work" (ahem). Once that's done, you just flick the switch on the relevant repo and a build will take place the next time someone pushes to the repo. You can see which applications are allowed to access your GitHub account at https://github.com/settings/applications. Hope that makes sense!

@paultcochrane

This comment has been minimized.

Collaborator

paultcochrane commented May 9, 2018

Another option would be if you give me admin privs on your repo, then I can link to Travis via my account. Just a thought; I can understand if that's going too far for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment