Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature reader reader does not work in Russian localization #653

Closed
gudvindll opened this issue Jul 15, 2018 · 7 comments
Closed

Signature reader reader does not work in Russian localization #653

gudvindll opened this issue Jul 15, 2018 · 7 comments
Assignees
Milestone

Comments

@gudvindll
Copy link

if the client has a localization language Russian then the reader writes that the error of reading the signature.

how fix it?

@exodus4d
Copy link
Owner

exodus4d commented Jul 16, 2018

Russian in "general" is not supported. But there are some essential keyWords translated that helps to map Russian Signature types e.g.:

Cosmic Anomaly -> Космическая аномали
Cosmic Signature -> Источники сигналов

If you want, you can past your Russian signature scan result in here, then I can try to figure out the English translation from EVE client and improve Russian support.

@gudvindll
Copy link
Author

I can scan in the English client tonight.
then switch the client language and scan again
that it would be easier for you to make a parser

@gudvindll
Copy link
Author

gudvindll commented Jul 17, 2018

i change
init.js

         1: {
                name: '(combat site|kampfgebiet|site de combat|Боевой район)', //*
                label: 'Combat'
            },
            2: {
                name: '(relic site|reliktgebiet|site de reliques|Археологический район)', //*
                label: 'Relic'
            },
            3: {
                name: '(data site|datengebiet|site de données|Информационный район)',
                label: 'Data'
            },
            4: {
                name: '(gas site|gasgebiet|site de collecte de gaz|Газовый район)',
                label: 'Gas'
            },
            5: {
                name: '(wormhole|wurmloch|trou de ver|Червоточина)',
                label: 'Wormhole'
            },
            6: {
                name: '(ore site|mineraliengebiet|site de minerai|Астероидный район)',
                label: 'Ore'
            },
            7: {
                name: '(ghost|Призрачный)',
                label: 'Ghost'
            }


and system_signature.js

 let validSignatureNames = [                                                 // allowed signature type/names
       'Cosmic Anomaly',
       'Cosmic Signature',
       'Kosmische Anomalie',
       'Kosmische Signatur',
       'Anomalie cosmique',
       'Signature cosmique',
       'Космическая аномалия',                                                 // == "Cosmic Anomaly"
       'Скрытый сигнал'                                                    	// == "Cosmic Signature"
   ];

but it doesn't work

I first thought it was because of the encodings utf-8
but the texts 'Космическая аномалия',is worked
Everything else added and corrected does not work for me.

@exodus4d
Copy link
Owner

@tezdal It probably not works because the JS files are not used in the client as they are. There is a "frontend build" process that bundles/minifies all the JS files.
But this is no problem I´ll add the labels you posted here and do the rest. :) Hopefully I can add the stuff before the next Pathfinder release gets out this weekend.

Thanks!

@gudvindll
Copy link
Author

but i use npm run gulp production and compile product.

These code fragments are still encountered in
public/v1.3.5/app/

@maiaz
Copy link

maiaz commented Mar 16, 2019

FYI 1.4.3 still not work w/ russian signatures :(

@exodus4d exodus4d self-assigned this Apr 20, 2019
@exodus4d exodus4d added this to the v1.5.1 milestone Apr 20, 2019
@exodus4d
Copy link
Owner

@tezdal Thanks for your translation!
I added your suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants