Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A-Frame scene missing elements or doesn't load #1160

Closed
kfarr opened this issue Jun 2, 2019 · 9 comments

Comments

Projects
None yet
2 participants
@kfarr
Copy link

commented Jun 2, 2019

Describe the bug
What happened, and what did you expect to happen?

A-Frame scene that loads on Chrome ("normal") and FF (in webvr) is missing elements or doesn't load at all when loaded via exokit.

To Reproduce
Steps or commands ran to reproduce the behavior:

  1. Go to this url:
    https://kfarr.github.io/aframe-bus/test-bus-wasd.html

works as expected in chrome (not vr), firefox (webvr 1.1 mode with steamvr)
chrome-ff-Screenshot (44)

see screenshot and note the green background from the a-frame "environment" component and the bus constructed using the "template" component

does not work as expected in exokit
exokit-Screenshot (45)

if I remove the environment component, the scene renders:
https://kfarr.github.io/aframe-bus/test-bus-wasd-no-env.html
exokit-no-env-Screenshot (46)

however, the bus is still missing (template component doesn't work as expected)

Additional context
Add any other context about the problem here.

aframe 0.9.2

System information:

  • OS: [e.g. Windows 10]
    Version 10.0.17134 Build 17134

  • Exokit Version [e.g. v0.0.512]
    exokit 0.0.525

  • Node version

  • Npm version/build log if applicable

  • Is your Exokit downloaded or built?

Screenshots
If applicable, add screenshots to help explain your problem.

@modulesio modulesio added the bug label Jun 2, 2019

@modulesio

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

Thanks, looks like a legitimate window messaging issue, possibly in the timing of the VR entry.

@modulesio

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Is your Exokit downloaded or built?

@kfarr to clarify, was this running a GitHub downloaded release (0.0.525)?

In Discord it was implied this was a custom build -- in that case, could you check if this bug is fixed in master and provide the git hash if it's not?

@kfarr

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

@kfarr

This comment has been minimized.

Copy link
Author

commented Jun 8, 2019

The exokit repo hash for the original ticket was: 3a5c85b

Just updated to: f01d085

The environment component now loads as expected and I no longer see window errors on the console, but the bus object using the template component [1] does not load.
Screenshot (48)

Tonight I can make a simpler test scene that only uses the template component to better isolate the error. Meanwhile for my application I can workaround by not using that component.

[1] https://github.com/supermedium/superframe/tree/master/components/template

@kfarr

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

I created an isolated test scene for the template component: https://aframe-template-component-test.glitch.me/

The console output shows a javascript error related to using template variables:
Screenshot (50)

@modulesio

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Thanks for the follow up! This should be sufficient for us to debug the template implementation.

@kfarr

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

I also made a test version without template variables and unfortunately I don't see any error message in console but it does not render as expected compared to chrome or ff:
https://aframe-template-component-test.glitch.me/novars.html

Screenshot (52)

@modulesio

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

The bus template is loading fine for me with those two PR's.

@kfarr

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

Awesome confirmed works!
kfarr/aframe-bus@c732fee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.