New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phenix2 #229

Merged
merged 3 commits into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@visze
Contributor

visze commented Sep 29, 2017

  • cherry pick jannovar0.23 commit
  • add default BOQA runner to AnalysisBuilder
  • fixing bug in BOQAPriority: Exeption was raised and Exomiser was terminated if an HPO ID string was not available. No it is handled similar to PHENIX. Term was removed and and a warning was logged.

julesjacobsen and others added some commits Sep 7, 2017

Updated jannovar to version 0.23, guava to 0.22, spring boot to 1.5.6…
…-RELEASE and spring platform to Brussels-SR4.

Changed remaining project.version -> project.parent.version
checking if the boqaa Ontology knows HPO id string. Removing the ID i…
…f it is not ablte to find it and log it
@drseb

This comment has been minimized.

Member

drseb commented Sep 29, 2017

Regarding e7614d8 . Thanks!

@julesjacobsen

This comment has been minimized.

Contributor

julesjacobsen commented Mar 9, 2018

Are you guys still working on this?

@drseb

This comment has been minimized.

Member

drseb commented Mar 9, 2018

The goal of this ticket was to have BOQA in Exomiser. This was achieved - so I am closing. Please re-open if you disagree.

@drseb drseb closed this Mar 9, 2018

@drseb drseb reopened this Mar 9, 2018

@drseb

This comment has been minimized.

Member

drseb commented Mar 9, 2018

Or wait... You haven't merged it? Is this intentional?

@drseb

This comment has been minimized.

Member

drseb commented Mar 13, 2018

@julesjacobsen would it be possible to get a brief comment on the merge-status here? (I.e. why no merge)
I have no problem leaving it unmerged, but would like to better understand the reasoning, so I can learn for other projects. Thanks.

@julesjacobsen julesjacobsen merged commit 3271929 into exomiser:phenix2 Mar 13, 2018

1 check passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
@julesjacobsen

This comment has been minimized.

Contributor

julesjacobsen commented Mar 13, 2018

Sorry @drseb I just overlooked it and no-one badgered me to merge it in so I assumed no one was working on it any more.

So is this really done? Have you benchmarked it vs PhenIX?

@pnrobinson

This comment has been minimized.

pnrobinson commented Mar 13, 2018

@drseb can you present your work on Phenix(2) during one of the monarch calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment