New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder imports (treat all 'extern create' as thirdparty) #397
Reorder imports (treat all 'extern create' as thirdparty) #397
Conversation
What do you think about order such this? use std;
use foreign_crates;
use exonum_crates;
use current_crate; |
Let's be closer to community convention ? use third_party_crates;
use std;
use current_crate;
pub use current_crate; P.S. third_party_crates include exonum's crates as external dependencies |
I like this idea, especially because it seems that |
Discussed, the following order should be used: use std;
...
use extern_crate;
...
use inner;
...
pub use something; Motivation: it is a popular ordering in other crates and in the rust-fmt RFC. |
It'd be grate if you save this somewhere in a public place |
Reorder imports (treat all 'extern create' as thirdparty)
Motivation: we had a (not described formally) convention to separate usings into three groups: first thirdparty, then
std
and finally the internal ones. I propose to treat allexternal crate
usings as thirdparty just because it is a formal criteria.The order is discussable too.