feat(sos-download): Add flag that allows overwriting the destination #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falzm
suggested changes
May 25, 2020
cmd/sos_download.go
Outdated
| func init() { | ||
| sosCmd.AddCommand(downloadCmd) | ||
| downloadCmd.Flags().Bool("allow-overwrite", false, "Allow overwriting the destination") |
There was a problem hiding this comment.
I'd prefer we go with the usual parlance in CLI tools:
Suggested change
| downloadCmd.Flags().Bool("allow-overwrite", false, "Allow overwriting the destination") | |
| downloadCmd.Flags().BoolP("force", "f", false, "Overwrite the destination file if it already exists") |
There was a problem hiding this comment.
Will do. I'll refactor the variable names to force as well.
| return err | ||
| } else if exists { | ||
| return fmt.Errorf("file %q: already exists", localFilePath) | ||
| } | ||
| } |
There was a problem hiding this comment.
An alternative implementation
allowOverwrite, err := cmd.Flags().GetBool("allow-overwrite")
if err != nil {
return err
}
if !allowOverwrite {
exists, err := destinationExists(localFilePath, objectName)
if err != nil {
return err
}
if exists {
return fmt.Errorf("file %q: already exists", localFilePath)
}
}
pierre-emmanuelJ
approved these changes
May 25, 2020
wdullaer
force-pushed
the
sos-download-overwrite
branch
from
b9b6376
to
3a502a6
Compare
falzm
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to
exo sos downloadwhich will skip the file existence check.It's off by default.
There are scenarios where this is valid behaviour.
Slightly related: I think that the
os.Renamestep at https://github.com/exoscale/cli/compare/sos-download-overwrite?expand=1#diff-cbe63d0320814a34674804f20dcfac94R140 does not take into account the case wherelocalFilePathis a directory, and thus needs to be appended withobjectName.