Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to next.jdbc #10

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@mpenet
Copy link
Member

mpenet commented Nov 7, 2019

It's a first stab at it. I probably didn't use all the new options from .next yet but I already applied a few improvements like fusing part of the result transforms. Something I didn't do is take advantage of is builder-fn to create entity col names labels on the fly, it still uses the legacy code.
It's quite conservative since we're relying on seql quite a bit, I didn't want to take too many risks for a first step.

One important diff would be the way update success is indicated, we should favor using the function I added for this instead of the [1] value like in the past.
Also the way the config is specified changed, as seen in d624f49#diff-85435b9b2af513f2ef158094336b73d7L6
Another minor change would be that ddl functions are gone and the fixture format is different.

refs #3

@mpenet mpenet force-pushed the feature/jdbc-next branch from b7ec55c to d624f49 Nov 7, 2019
@mpenet mpenet requested a review from pyr Nov 7, 2019
@mpenet mpenet force-pushed the feature/jdbc-next branch from 76ada48 to 062f123 Nov 7, 2019
@pyr
pyr approved these changes Nov 7, 2019
Copy link
Member

pyr left a comment

I like the gradual approach, we can start shaving code off and prefer next.jdbc in a second step.

@mpenet mpenet merged commit 5225c81 into master Nov 7, 2019
@mpenet mpenet deleted the feature/jdbc-next branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.