Skip to content

fix: handle tuple-formatted entities in SingleHopSpecificQuerySynthesizer #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix: handle tuple-formatted entities in SingleHopSpecificQuerySynthesizer #2377

merged 1 commit into from
Oct 27, 2025

Conversation

@anistark
Copy link
Member

Issue Link / Problem Description

Changes Made

  • helper method _extract_themes_from_items to handle various formats

Testing

How to Test

  • Automated tests added/updated

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@anistark anistark mentioned this pull request Oct 23, 2025
Closed
@anistark anistark merged commit b113f52 into explodinggradients:main Oct 27, 2025
9 checks passed
@anistark anistark deleted the fix/theme-tuple-string branch October 27, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValidationError: 2 validation errors for ThemesPersonasInput when generating test dataset

1 participant

@anistark