From 8c9942c84b1983f97b8a4693cd67e42a31b941d0 Mon Sep 17 00:00:00 2001
From: jjmachan <jamesjithin97@gmail.com>
Date: Fri, 23 Feb 2024 00:57:58 -0800
Subject: [PATCH 1/3] fix: added types so you can pass langchain llms and
 embeddings too

---
 src/ragas/evaluation.py | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/ragas/evaluation.py b/src/ragas/evaluation.py
index b518709f1..f697b8a96 100644
--- a/src/ragas/evaluation.py
+++ b/src/ragas/evaluation.py
@@ -10,7 +10,11 @@
 
 from ragas._analytics import EvaluationEvent, track
 from ragas.callbacks import new_group
-from ragas.embeddings.base import BaseRagasEmbeddings, LangchainEmbeddingsWrapper, embedding_factory
+from ragas.embeddings.base import (
+    BaseRagasEmbeddings,
+    LangchainEmbeddingsWrapper,
+    embedding_factory,
+)
 from ragas.llms import llm_factory
 from ragas.exceptions import ExceptionInRunner
 from ragas.executor import Executor
@@ -36,8 +40,8 @@
 def evaluate(
     dataset: Dataset,
     metrics: list[Metric] | None = None,
-    llm: t.Optional[BaseRagasLLM] = None,
-    embeddings: t.Optional[BaseRagasEmbeddings] = None,
+    llm: t.Optional[BaseRagasLLM | LangchainLLM] = None,
+    embeddings: t.Optional[BaseRagasEmbeddings | LangchainEmbeddings] = None,
     callbacks: Callbacks = [],
     is_async: bool = False,
     max_workers: t.Optional[int] = None,

From 4310ebf248f64c5fbe27f9132ce37dd487b9bd70 Mon Sep 17 00:00:00 2001
From: jjmachan <jamesjithin97@gmail.com>
Date: Fri, 23 Feb 2024 01:00:31 -0800
Subject: [PATCH 2/3] brought out emb_fact

---
 src/ragas/embeddings/__init__.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/ragas/embeddings/__init__.py b/src/ragas/embeddings/__init__.py
index 72a02a334..e78a95b99 100644
--- a/src/ragas/embeddings/__init__.py
+++ b/src/ragas/embeddings/__init__.py
@@ -2,10 +2,12 @@
     BaseRagasEmbeddings,
     HuggingfaceEmbeddings,
     LangchainEmbeddingsWrapper,
+    embedding_factory,
 )
 
 __all__ = [
     "HuggingfaceEmbeddings",
     "BaseRagasEmbeddings",
     "LangchainEmbeddingsWrapper",
+    "embedding_factory",
 ]

From 394b9066b462cbd87c1fab34b8fc833fbb0d60e7 Mon Sep 17 00:00:00 2001
From: jjmachan <jamesjithin97@gmail.com>
Date: Fri, 23 Feb 2024 01:15:43 -0800
Subject: [PATCH 3/3] raise exceptions is true

---
 src/ragas/evaluation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ragas/evaluation.py b/src/ragas/evaluation.py
index f697b8a96..1ef5588e9 100644
--- a/src/ragas/evaluation.py
+++ b/src/ragas/evaluation.py
@@ -83,7 +83,7 @@ def evaluate(
     run_config: RunConfig, optional
         Configuration for runtime settings like timeout and retries. If not provided,
         default values are used.
-    raise_exceptions: bool, optional
+    raise_exceptions: True
         Whether to raise exceptions or not. If set to True then the evaluation will
         raise an exception if any of the metrics fail. If set to False then the
         evaluation will return `np.nan` for the row that failed. Default is True.