From cbf848ee05ceb03c6784f9adfd8e2db8baaa4a1f Mon Sep 17 00:00:00 2001 From: jjmachan Date: Thu, 27 Jul 2023 19:06:40 +0530 Subject: [PATCH] fix: validation was incorrect --- src/ragas/validation.py | 2 +- tests/unit/test_validation.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ragas/validation.py b/src/ragas/validation.py index 8b99f70c7..c8c1c5d44 100644 --- a/src/ragas/validation.py +++ b/src/ragas/validation.py @@ -47,7 +47,7 @@ def validate_evaluation_modes(ds: Dataset, metrics: list[Metric]): for m in metrics: required_columns = set(EVALMODE_TO_COLUMNS[m.evaluation_mode]) available_columns = set(ds.features.keys()) - if required_columns.symmetric_difference(available_columns): + if not required_columns.issubset(available_columns): raise ValueError( f"The metric [{m.name}] that that is used requires the following " f"additional columns {list(required_columns - available_columns)} " diff --git a/tests/unit/test_validation.py b/tests/unit/test_validation.py index 146b306d8..10259f9db 100644 --- a/tests/unit/test_validation.py +++ b/tests/unit/test_validation.py @@ -12,15 +12,15 @@ TEST_CASES = [ CaseToTest("a", "b", ["c"], None, True, [faithfulness], True), - CaseToTest("a", "b", ["c"], ["g"], True, [faithfulness], False), + CaseToTest("a", "b", ["c"], ["g"], True, [faithfulness], True), CaseToTest("a", None, ["c"], None, True, [context_relevancy], True), CaseToTest("a", None, "c", None, False, [context_relevancy], True), CaseToTest( "a", None, [["c"]], None, False, [context_relevancy, answer_relevancy], False ), - CaseToTest("a", None, ["c"], "g", False, [context_relevancy], False), - CaseToTest("a", None, ["c"], [["g"]], False, [context_relevancy], False), - CaseToTest(1, None, ["c"], ["g"], False, [context_relevancy], False), + CaseToTest("a", None, ["c"], "g", False, [context_relevancy], True), + CaseToTest("a", None, ["c"], [["g"]], False, [context_relevancy], True), + CaseToTest(1, None, ["c"], ["g"], False, [context_relevancy], True), CaseToTest(1, None, None, None, False, [context_relevancy], False), ]