Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for cycles in dependency trees to debug-data CLI #4096

Closed
adrianeboyd opened this issue Aug 8, 2019 · 3 comments
Closed

Add check for cycles in dependency trees to debug-data CLI #4096

adrianeboyd opened this issue Aug 8, 2019 · 3 comments
Labels
enhancement Feature requests and improvements feat / cli Feature: Command-line interface

Comments

@adrianeboyd
Copy link
Contributor

Feature description

The debug-data CLI should also check for cycles in dependency trees.

Cycles should be identified elsewhere, too, to prevent the kind of error from #4083, but a check in debug-data would also be helpful.

@adrianeboyd
Copy link
Contributor Author

Wait, I already get the ValueError [E069] from GoldCorpus when the corpus is loaded, so maybe it is just a matter of reporting that more cleanly.

@ines ines added enhancement Feature requests and improvements feat / cli Feature: Command-line interface labels Aug 8, 2019
@ines
Copy link
Member

ines commented Aug 8, 2019

Yes, that's a good idea! It might also be nice to test the debug-data a bit more thoroughly to make sure it really works as expected – and then I can document it properly 🙂 (It's currently still considered experimental and thus undocumented – but it has held up really well and people who've tried it found it very useful.)

@lock
Copy link

lock bot commented Sep 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Feature requests and improvements feat / cli Feature: Command-line interface
Projects
None yet
Development

No branches or pull requests

2 participants