Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS Mapping to UD #593

Closed
chrisjbryant opened this Issue Oct 29, 2016 · 3 comments

Comments

Projects
4 participants
@chrisjbryant
Copy link

commented Oct 29, 2016

Congrats on spacy v1.0!

I just wanted to remind you that the tag_map.json to convert PTB tags to UD tags still doesn't reflect the one on the Stanford website: http://universaldependencies.org/tagset-conversion/en-penn-uposf.html
C.f. #191

I believe I've fixed your current version (attached):
tag_map.txt

The only lines that were changed:
"NIL": {"pos": "x"},
"PDT": {"pos": "det", "adjtype": "pdt", "prontype": "prn"},
"PRP$": {"pos": "det", "prontype": "prs", "poss": "poss"},
"WDT": {"pos": "det", "prontype": "int|rel"},
"WP": {"pos": "pron", "prontype": "int|rel"},
"WP$": {"pos": "det", "poss": "poss", "prontype": "int|rel"},
"AFX": {"pos": "x"}, - repeated, so deleted.
"HYPH": {"pos": "punct"}, - repeated, so deleted.

@honnibal honnibal added the performance label Nov 5, 2016

@honnibal honnibal moved this from 📌 To Do to 🔍 Under Review in 💫 spaCy v2.0 Oct 16, 2017

@ines ines added enhancement and removed 🌙 nightly labels Nov 9, 2017

@ines ines added the feat / tagger label Mar 27, 2018

@ines ines removed the performance label Aug 15, 2018

@christian-storm

This comment has been minimized.

Copy link

commented Dec 21, 2018

Is there a reason this is still outstanding, e.g., don't want to introduce a breaking change? Do you disagree with the UD, e.g., WDT -> DET? Spacy confusingly maps WDT -> ADJ even though the description reads 'wh-determiner'?

Happy Holidays!

@honnibal

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Sorry for not attending to this sooner. It got left out of the 2.0 changes, and then I kept glancing over the issue and not seeing that it was very simple. I think I was also worried about backwards compatibility. Will be patched in v2.1.

Fortunately we've steadily got the issue tracker under control, so these sorts of oversights shouldn't occur in future...

@honnibal honnibal closed this Mar 10, 2019

honnibal added a commit that referenced this issue Mar 10, 2019

@lock

This comment has been minimized.

Copy link

commented Apr 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.