Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change postags to parts_of_speech #4

Closed
wants to merge 3 commits into from

Conversation

mrshu
Copy link
Contributor

@mrshu mrshu commented Jan 25, 2015

  • It seems that the docs use spacy.postags but the actual module that
    can be found in spacy/ is parts_of_speech.

Signed-off-by: mr.Shu mr@shu.io


@honnibal I am sorry if you would like to move parts_of_speech to postags but the sample code in index.rst was not working for me. These changes make it functional.

* It seems that the docs use `spacy.postags` but the actual module that
  can be found in `spacy/` is `parts_of_speech`.

Signed-off-by: mr.Shu <mr@shu.io>
* It turns out `ADVERB` is not in `parts_of_speech`

Signed-off-by: mr.Shu <mr@shu.io>
@honnibal
Copy link
Member

Yeah, I didn't update that snippet. Damn, thanks!

@honnibal honnibal closed this Jan 25, 2015
@honnibal honnibal reopened this Jan 25, 2015
…stags-fix

Signed-off-by: mr.Shu <mr@shu.io>

Conflicts:
	docs/source/index.rst
@mrshu
Copy link
Contributor Author

mrshu commented Jan 25, 2015

@honnibal there has been a merge conflict which should be resolved now and this pull request can be merged again.

@honnibal
Copy link
Member

It was easier just to apply this patch manually. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants