New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error if deps not provided with heads #8335
Conversation
Before this change, if heads were passed without deps they would be silently ignored, which could be confusing. See explosion#8334.
It would be better to use a non-empty string here, and we normally use The problem with the head attribute is that there's no value for a missing head, so in |
This is the customary placeholder dep. It might be better to show an error here instead though.
I think an error as Matt suggested would be fine as an alternative to this. You could give a suggestion about how to fill in default deps as |
Huh, turns out there's more than few tests that pass heads without deps. |
Looks fine, I will just do some minor whitespace cleanup. |
* Fill in deps if not provided with heads Before this change, if heads were passed without deps they would be silently ignored, which could be confusing. See explosion#8334. * Use "dep" instead of a blank string This is the customary placeholder dep. It might be better to show an error here instead though. * Throw error on heads without deps * Add a test * Fix tests * Formatting * Fix all tests * Fix a test I missed * Revise error message * Clean up whitespace Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Before this change, if heads were passed without deps they would be
silently ignored, which could be confusing. See #8334.
Description
Types of change
Minor bugfix
Checklist