Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5622] allow importing devices from Apple Developer Portal #1236

Merged
merged 2 commits into from Jul 29, 2022

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Jul 28, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

Adds a new option to eas device:create. It allows importing devices from Apple Developer Portal.

How

Use @expo/apple-utils for fetching devices from Apple Developer Portal and display a multi-select for importing them to EAS.

Test Plan

Screen.Recording.2022-07-28.at.13.36.44.mov
Screen.Recording.2022-07-28.at.13.30.05.mov

@linear
Copy link

linear bot commented Jul 28, 2022

ENG-5622 Investigate using existing devices for adhoc deployments

I think this is a valid question. Do we have a way to use existing devices? Afaik, they don't show up for selection unless we 'know' about them through eas device:create.

@github-actions
Copy link

Size Change: +1.38 kB (0%)

Total Size: 25.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.1 MB +1.38 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1236 (d36523c) into main (5f73b0a) will decrease coverage by 0.07%.
The diff coverage is 36.00%.

❗ Current head d36523c differs from pull request most recent head 354a1fb. Consider uploading reports for the commit 354a1fb to get more accurate results

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   51.38%   51.31%   -0.06%     
==========================================
  Files         383      385       +2     
  Lines       13612    13683      +71     
  Branches     2654     2666      +12     
==========================================
+ Hits         6993     7020      +27     
- Misses       6607     6651      +44     
  Partials       12       12              
Impacted Files Coverage Δ
...tials/ios/actions/SetUpAdhocProvisioningProfile.ts 20.94% <0.00%> (ø)
packages/eas-cli/src/devices/manager.ts 64.71% <0.00%> (ø)
...rc/devices/actions/create/developerPortalMethod.ts 22.81% <22.81%> (ø)
...kages/eas-cli/src/devices/actions/create/action.ts 87.10% <100.00%> (+2.49%) ⬆️
packages/eas-cli/src/utils/expodash/chunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f73b0a...354a1fb. Read the comment docs.

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@dsokal
Copy link
Contributor Author

dsokal commented Jul 29, 2022

/changelog-entry new-feature Add new option to eas device:create - allow importing devices from Apple Developer Portal.

@dsokal dsokal merged commit 2023f61 into main Jul 29, 2022
@dsokal dsokal deleted the @dsokal/device-create-import-from-dev-portal branch July 29, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants