This repository has been archived by the owner. It is now read-only.

clear RN packager cache before publish #88

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@slorber
Contributor

slorber commented Dec 6, 2017

When you publish your project, you might use different environment variables than the ones used when developing.

If you don't clear the RN packager cache, you might publish to Expo production the Js bundle that is suited for your local development, and former env variable values (suited for local dev) are cached.

See related issue: react-community/create-react-native-app#500

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 6, 2017

see also related Metro issue: facebook/metro#105

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 6, 2017

if you think it should not be a default, I can submit a new PR for an option?

@anp

This comment has been minimized.

Contributor

anp commented Dec 6, 2017

Thanks for the PR! Reading the info on the CRNA issue, it does seem useful to support.

cc @fson, but I'd prefer to make this opt-in via a CLI flag. EDIT: my reasoning is that a cold packager cache is pretty brutal on a lot of people's machines, and since most users don't seem to depend on transforms like this I don't want to slow publishing down for them.

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 7, 2017

I've updated the PR to make it an option

@anp anp requested a review from fson Dec 11, 2017

@fson fson closed this Dec 12, 2017

@fson

This comment has been minimized.

Member

fson commented Dec 12, 2017

Thanks! This has been merged.

expbot added a commit that referenced this pull request Dec 12, 2017

clear RN packager cache before publish
When you publish your project, you might use different environment variables than the ones used when developing.

If you don'\''t clear the RN packager cache, you might publish to Expo production the Js bundle that is suited for your local development, and former env variable values (suited for local dev) are cached.

See related issue: react-community/create-react-native-app#500

Closes #88

fbshipit-source-id: 0a345ef

fson added a commit to expo/expo-cli that referenced this pull request Aug 16, 2018

[exp] clear RN packager cache before publish
When you publish your project, you might use different environment variables than the ones used when developing.

If you don'\''t clear the RN packager cache, you might publish to Expo production the Js bundle that is suited for your local development, and former env variable values (suited for local dev) are cached.

See related issue: react-community/create-react-native-app#500

Closes expo/exp#88

fson added a commit to expo/expo-cli that referenced this pull request Aug 23, 2018

[exp] clear RN packager cache before publish
When you publish your project, you might use different environment variables than the ones used when developing.

If you don'\''t clear the RN packager cache, you might publish to Expo production the Js bundle that is suited for your local development, and former env variable values (suited for local dev) are cached.

See related issue: react-community/create-react-native-app#500

Closes expo/exp#88
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.