This repository has been archived by the owner. It is now read-only.

Option to display QRCode even on detached projects #89

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@fson

This comment has been minimized.

Member

fson commented Mar 2, 2018

Thanks for the PR and sorry for the long response time. We don't display QR codes for detached projects, because there's no guarantee that they work with Expo Client. See #101 (comment).

@fson fson closed this Mar 2, 2018

@slorber

This comment has been minimized.

Contributor

slorber commented Mar 2, 2018

@fson yes I know there is no guarantee, this is why I made this an option.

The idea of this option is that, if you are sure the detached project can work inside Expo client, then you use this option so that QRCode is displayed. This option would not be used most of the time.

Take a look at this first to understand: https://expo.canny.io/feature-requests/p/ability-to-work-in-expo-client-after-detaching

@terribleben

This comment has been minimized.

Contributor

terribleben commented Mar 2, 2018

Hi, can you help us understand your use case more?

I read your canny request, and I'm still not sure I understand the value of this workflow. By definition, apps that need to be detached pretty much always stop working in Expo Client. I realize you can do a bunch of work to guard against this by wrapping all your api calls (as you detailed in the canny request), but that sounds like it would be a ton of work for most projects, and lead to confusion for people and higher support burden for Expo. It's already fairly hard to work in ExpoKit projects (which is something we're working on improving) and I'm wary about adding even more complexity to the process unless this would be super valuable for a lot of users right away.

Since you're linking against native code and writing native code, is there something wrong with the current workflow of deploying your detached binary from Xcode instead of using Expo Client?

@slorber

This comment has been minimized.

Contributor

slorber commented Mar 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.