This repository has been archived by the owner. It is now read-only.

Picture Frame Guides #6

Closed
m-a-r-c-e-l-i-n-o opened this Issue Oct 5, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@m-a-r-c-e-l-i-n-o

m-a-r-c-e-l-i-n-o commented Oct 5, 2018

Hello there!

Any plans to add support for frame guides to help the user better focus on barcodes and/or other regions of a picture?

Maybe something along the lines of:

<Camera
    frame={true} // enable and disable frame guides
    frameColor={"green"} // The color of the borders of the frame guides
    frameRatio = {16:9} // The ratio of the frame
/>

I suppose it could always be centered and stretched to the max width or height allowed by the ratio, with maybe a 10% padding for clarity.

Thanks for the expo system, really loving it!

@sjchmiela

This comment has been minimized.

Contributor

sjchmiela commented Oct 10, 2018

Hey, @m-a-r-c-e-l-i-n-o!

I'm not sure what you mean by frame guides, but if what you mean are these guiding lines in the live preview of the camera, like:

camera app screenshot

then you can do it on your own! Camera component accepts children, so you could design such frames component yourself and pass in as a child. 🙂

@sjchmiela

This comment has been minimized.

Contributor

sjchmiela commented Nov 6, 2018

I'll close this issue as the frame guides can be implemented by the developer (putting it into expo-camera wouldn't necessary align with the purpose of this package). 🙂

@sjchmiela sjchmiela closed this Nov 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.