From cbbca5ddaba2330cb9bf6d9721d952a34880705a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Bukowski?= Date: Thu, 24 Sep 2020 17:07:47 +0200 Subject: [PATCH] [configure-splash-screen] : Accomodate Android API change https://github.com/expo/expo/pull/10294 introduces scoping to SplashScreen object used in project's MainActivity --- .../configure-splash-screen/src/android/MainActivity.ts | 6 +++--- .../src/android/__tests__/MainActivity.test.ts | 2 +- ...ative-project-structure-with-splash-screen-configured.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/configure-splash-screen/src/android/MainActivity.ts b/packages/configure-splash-screen/src/android/MainActivity.ts index a9f200745d..ab3c508acd 100644 --- a/packages/configure-splash-screen/src/android/MainActivity.ts +++ b/packages/configure-splash-screen/src/android/MainActivity.ts @@ -68,8 +68,8 @@ export default async function configureMainActivity( // importing SplashScreen .applyAction(content => { const [succeeded, newContent] = replace(content, { - replacePattern: /^import expo\.modules\.splashscreen\.SplashScreen.*?\nimport expo\.modules\.splashscreen\.SplashScreenImageResizeMode.*?$/m, - replaceContent: `import expo.modules.splashscreen.SplashScreen${LE} + replacePattern: /^import expo\.modules\.splashscreen\..*?SplashScreen.*?\nimport expo\.modules\.splashscreen\.SplashScreenImageResizeMode.*?$/m, + replaceContent: `import expo.modules.splashscreen.singletons.SplashScreen${LE} import expo.modules.splashscreen.SplashScreenImageResizeMode${LE}`, }); return [newContent, 'replacedSplashImports', succeeded]; @@ -80,7 +80,7 @@ import expo.modules.splashscreen.SplashScreenImageResizeMode${LE}`, } const [succeeded, newContent] = insert(content, { insertPattern: isJava ? /(?=public class .* extends .* {.*$)/m : /(?=class .* : .* {.*$)/m, - insertContent: `import expo.modules.splashscreen.SplashScreen${LE} + insertContent: `import expo.modules.splashscreen.singletons.SplashScreen${LE} import expo.modules.splashscreen.SplashScreenImageResizeMode${LE} `, diff --git a/packages/configure-splash-screen/src/android/__tests__/MainActivity.test.ts b/packages/configure-splash-screen/src/android/__tests__/MainActivity.test.ts index 6256493fa5..2f19996d0c 100644 --- a/packages/configure-splash-screen/src/android/__tests__/MainActivity.test.ts +++ b/packages/configure-splash-screen/src/android/__tests__/MainActivity.test.ts @@ -56,7 +56,7 @@ ${ !addSplashScreenShowWith ? '' : ` -import expo.modules.splashscreen.SplashScreen${LE} +import expo.modules.splashscreen.singletons.SplashScreen${LE} import expo.modules.splashscreen.SplashScreenImageResizeMode${LE} ` } diff --git a/packages/configure-splash-screen/src/android/__tests__/fixtures/react-native-project-structure-with-splash-screen-configured.ts b/packages/configure-splash-screen/src/android/__tests__/fixtures/react-native-project-structure-with-splash-screen-configured.ts index 8285a43ea1..f08e3de95e 100644 --- a/packages/configure-splash-screen/src/android/__tests__/fixtures/react-native-project-structure-with-splash-screen-configured.ts +++ b/packages/configure-splash-screen/src/android/__tests__/fixtures/react-native-project-structure-with-splash-screen-configured.ts @@ -7,7 +7,7 @@ import com.facebook.react.ReactActivity; import com.facebook.react.ReactRootView; -import expo.modules.splashscreen.SplashScreen; +import expo.modules.splashscreen.singletons.SplashScreen; import expo.modules.splashscreen.SplashScreenImageResizeMode; public class MainActivity extends ReactActivity {