Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure "Run on web browser" respects network setting #1190

Closed
wants to merge 1 commit into from

Conversation

@sstur
Copy link
Contributor

sstur commented Nov 9, 2019

The current behavior is that clicking "Run on web browser" will always use the computer's LAN address, even if the user selected "Local" for the network setting. This even happens when the option --host localhost was specified on the expo start command, which is probably not what the user expects.

Note: this is a bit of a client-side hack.

@sstur

This comment has been minimized.

Copy link
Contributor Author

sstur commented Nov 9, 2019

I'm closing this in favor of #1191 which fixes it at the source of truth.

@sstur sstur closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.