Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure webAppUrl respects network setting (LAN/Local) #1191

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@sstur
Copy link
Contributor

sstur commented Nov 9, 2019

The current behavior of constructWebAppUrlAsync is to always use the LAN IP, even if the user selected "Local" for the network setting (either in the UI or the option --host localhost was specified). This is probably not what the user expects.

Note: This is a better solution than #1190 since it fixes the issue at the source, where the URL is generated.

@sstur sstur force-pushed the sstur:fixWebAppURL2 branch from 0a81c08 to 41e8572 Nov 9, 2019
@fson

This comment has been minimized.

Copy link
Member

fson commented Nov 11, 2019

Makes sense, thanks for fixing this! 🙌

@fson fson merged commit 7f546e4 into expo:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.