Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[cli] Use update-check for updates #2589

Closed
wants to merge 3 commits into from

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Sep 7, 2020

  • We use update-check in all of our other CLIs.
  • Removes a bunch of dependency bloat and another XDL module.
  • Simplifies the upgrade message.
  • Prompts to use yarn for global installs based on expo/package-manager.
  • Removes deprecated support, not sure how important this is but it seems like it'll be tedious to add.

Screen Shot 2020-09-07 at 12 07 50 PM

@EvanBacon EvanBacon requested a review from fson September 7, 2020 10:22
@EvanBacon EvanBacon self-assigned this Sep 7, 2020
@brentvatne
Copy link
Member

aside from making sure we cache the latest version for some reasonable interval this pr lgtm

@brentvatne
Copy link
Member

update from previous comment after discussing this on call - would be good to know about deprecated flag too, so we can more strongly encourage an update

@fson
Copy link
Contributor

fson commented Sep 23, 2020

Vercel no longer uses update-check in their own CLI: vercel/vercel@843be96 🤔 I wonder if they're going to keep maintaining it.

@EvanBacon EvanBacon closed this Oct 1, 2020
@EvanBacon EvanBacon deleted the @evanbacon/expo-cli/update-check branch November 18, 2020 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants