This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[BREAKING][cli] remove deprecated command functionality #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huynhdev24
approved these changes
Aug 4, 2023
huynhdev24
reviewed
Aug 4, 2023
|
@huynhdev24 When the server endpoints are removed, this command will stop working. The |
byCedric
approved these changes
Dec 12, 2023
byCedric
force-pushed
the
@quin/removeDeprecatedFn
branch
from
1063a0e
to
1ca4012
Compare
byCedric
force-pushed
the
@quin/removeDeprecatedFn
branch
from
1ca4012
to
b8fab6d
Compare
byCedric
added
expo:internal-discussion
byCedric
removed
the
expo:internal-discussion
|
Closing this due to inactivity. |
|
@quinlanj does it make sense to later revisit this, or abandon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Applying feedback from #4686 (review)
This PR removes deprecated command functionality. These changes should be made into a new major version release .
Test Plan