New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update push-notifications.md #108

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@slorber

slorber commented Aug 8, 2017

Improve documentation of push notifications:

  • Add curl example
  • Use non-deprecated api in example
  • Mention api does not require auth

Note that it may be nice to mention weither or not expo tokens are "stable" unlike Apns/GCM ones that can be revoked by the provider. Not sure about that so I didn't write it.

Update push-notifications.md
Improve documentation of push notifications:
- Add curl example
- Use non-deprecated api in example
- Mention api does not require auth

@abi abi self-requested a review Aug 15, 2017

@abi abi self-assigned this Aug 15, 2017

@abi

This comment has been minimized.

Contributor

abi commented Aug 15, 2017

Updated in main repo. Will be deployed shortly. Thank you!

@abi abi closed this Aug 15, 2017

expbot added a commit that referenced this pull request Aug 18, 2017

docs bugfixes, improvements, SEO opts (#836)
* [docs] upgrade all deps to latest (fixes #607)

* [docs] add noindex for unversioned URLs

* [docs] fix typo in expokit.md thanks to @ArmaizAdenwala

* [expo-docs] Document Sentry.enableInExpoDevelopment

Closes #112

* [docs] apply sentry doc updates to v19 as well

* [expo-docs] Improve ART docs

Closes #107

* [docs] update unversioned ART docs too

* [expo-docs] [docs] update Amplitude docs

Was reading through and saw that some links were broken, etc.

Closes #105

* [docs] update amplitude docs for unversioned

* [expo-docs] Add docs for new scheduling option intervalMs for local notif.

Documentation for expo/expo#380

Closes #114

* [docs] update v19 push notifications docs to reflect correct API thanks to @timarney

* [expo-docs] Include iOS status bar text color info

Explain about using <StatusBar /> to keep the status bar text black as is the default in Expo (otherwise users will most likely be surprised when they see a difference between Expo and Standalone, and building/submitting to TestFlight isn'\''t the funnest of processes.)

Closes #102

* [docs] move note about default status bar color to building standalone apps guide

* [expo-docs] Update push-notifications.md

Improve documentation of push notifications:
- Add curl example
- Use non-deprecated api in example
- Mention api does not require auth

Note that it may be nice to mention weither or not expo tokens are stable unlike Apns/GCM ones that can be revoked by the provider. Not sure about that so I didn'\''t write it.

Closes #108

* [docs] apply push-notification changes to unversioned as well

fbshipit-source-id: a4931f2
@slorber

This comment has been minimized.

slorber commented Aug 18, 2017

Hi @abi

By chance can you update the curl statement again? I've put my real expo token in the official doc and now I start to receive hello world push from strangers :D

image

@slorber

This comment has been minimized.

slorber commented Aug 18, 2017

not sure if I'm supposed to do a new PR as it seems you close them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment