New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release channel in Slack message #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@slorber
Contributor

slorber commented Nov 29, 2017

No description provided.

@@ -6,7 +6,7 @@ module.exports = ({ url, iosManifest, config }) => {
slack.send(
{
icon_url: iosManifest.iconUrl,
text: `${iosManifest.name} v${iosManifest.version} published to ${url}`,
text: `${iosManifest.name} v${iosManifest.version} published to ${url}. Channel=${iosManifest.releaseChannel || 'default'}`,

This comment has been minimized.

@slorber

slorber Nov 29, 2017

Contributor

@brentvatne maybe it would be better to put the release channel in url with a query string no?

This comment has been minimized.

@brentvatne

brentvatne Dec 1, 2017

Member

yeah i think that makes sense. if it's default, we can just leave it out entirely

@slorber slorber closed this Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment