New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release channel to url #2

Merged
merged 1 commit into from Feb 24, 2018

Conversation

Projects
None yet
2 participants
@slorber
Contributor

slorber commented Dec 1, 2017

@brentvatne wouldn't it make more sense that the url received from this hook does already include the release channel in it instead of building the url in all postpublish hooks?

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 1, 2017

I think Api.callMethodAsync('publish') should rather return url including the querystring.
Didn't check but this is probably not the case currently

@brentvatne brentvatne merged commit 0e9df9a into expo:master Feb 24, 2018

@brentvatne

This comment has been minimized.

Member

brentvatne commented Feb 24, 2018

@slorber - yeah that makes sense. we can update this if that changes. merged as is though, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment