Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Text TSpan dy behaves differently on Android and iOS #1393

Closed
lc3t35 opened this issue Feb 7, 2018 · 7 comments

Comments

Projects
None yet
6 participants
@lc3t35
Copy link

commented Feb 7, 2018

Environment

sdk 23 -24-25

Steps to Reproduce

This issue react-native-community/react-native-svg#377 happens due to the embedded version of react-native-svg equal to 5.5.1

Expected Behavior

use a fresher version (6 is rc) of react-native-svg or msand’s fork

Actual Behavior

react-native-svg equal to 5.5.1

Reproducible Demo

https://snack.expo.io/@lc3t35/tspan-dy-demo

@ccheever

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2018

Thanks for this report! Very helpful.

@slava-lu

This comment has been minimized.

Copy link

commented Feb 8, 2018

It would also be good if Expo guys put the library version in docs so that we new where the problem is. And please upgrade SVG as rather useful module - Victory Native does not work now,

@lc3t35

This comment has been minimized.

Copy link
Author

commented Feb 8, 2018

@slava-lu this is exactly what I was asking for in my post at expo.io's forum : https://forums.expo.io/t/which-versions-of-react-native-svg-are-built-with-each-sdk/6075

@Elijen

This comment has been minimized.

Copy link

commented Feb 12, 2018

I can confirm this is causing some ugly issues: FormidableLabs/victory-native#255

@robertobrogi

This comment has been minimized.

Copy link

commented Feb 14, 2018

yep i have the same problem...

@Elijen

This comment has been minimized.

Copy link

commented Feb 14, 2018

@robertobrogi As mentioned in the other issue it should work fine with victory-native@~0.15.0

@terribleben

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2018

We'll be updating rn-svg in Expo as soon as possible because we've resolved the upstream issue that was preventing us from updating earlier. react-native-community/react-native-svg#603

@ide ide closed this Feb 15, 2018

expbot added a commit that referenced this issue Feb 15, 2018

Update RN SVG for iOS
Why
 ---

This updates RN SVG by a major version so we don't fall behind too much.

Fixes #1393

How
 ---

Ran the vendoring scripts. Also needed to patch RN SVG so that NS_ENUMs weren't declared twice (sent a PR upstream to fix this).

Test Plan
 ---

Compiled & ran NCL on iOS and viewed the SVG demo -- this worked in a prior version of a PR but currently I can't load NCL in master so can't fully test. Previously text rendering changed (need to specify a y-offset now).

fbshipit-source-id: df5f7e8

expbot added a commit to expo/expo-sdk that referenced this issue Feb 15, 2018

Update RN SVG for iOS
Why
 ---

This updates RN SVG by a major version so we don't fall behind too much.

Fixes expo/expo#1393

How
 ---

Ran the vendoring scripts. Also needed to patch RN SVG so that NS_ENUMs weren't declared twice (sent a PR upstream to fix this).

Test Plan
 ---

Compiled & ran NCL on iOS and viewed the SVG demo -- this worked in a prior version of a PR but currently I can't load NCL in master so can't fully test. Previously text rendering changed (need to specify a y-offset now).

fbshipit-source-id: df5f7e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.