Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBAudienceNetwork 4.99.0 breaks iOS ExpoKit #1868

Closed
terribleben opened this issue Jun 13, 2018 · 18 comments

Comments

Projects
None yet
@terribleben
Copy link
Contributor

commented Jun 13, 2018

Facebook released a new version of FBAudienceNetwork yesterday with a bunch of breaking changes. Expo's ads module depends on the previous version, 4.28.1, but the dependency is listed as ~> 4.24.

  • Short term solution-- pin the dependency to the older version.
  • After that-- need to update our ads module to be compatible with 4.99.0.

Here's the full changelog.

@terribleben

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2018

Noting here that whenever we do update to be compatible with 4.99.0, this will be a breaking change to the Expo SDK as well (because it will remove the title and subtitle properties from our native ad callback in JS).

@terribleben

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2018

Solution for people who saw a build failure

I've pushed a new ExpoKit tag which pins our FBAudienceNetwork dependency to 4.28.1.

If you saw something like this: Property ‘title’ not found on object of type ‘FBNativeAd *’ while trying to build ExpoKit, then follow these instructions--

  1. Change your Podfile so that your ExpoKit tag points to ios/2.6.5 instead of 2.6.4.
  2. pod install
  3. Try building again

Note that this will downgrade your FBAudienceNetwork version. If you run into issues during pod install then you might want to nuke Pods and Podfile.lock and try again.

@ChildishDanbino

This comment has been minimized.

Copy link

commented Jun 13, 2018

@terribleben - Will this fix also fix solve the issue for those who are on older SDKs. Our production application was released today (using the fix mentioned in the last thread) on SDK 25. We are in the process of upgrading to SDK 26 and then onto SDK 27. Will this be fixed in those SDKs as well?

@poptocrack

This comment has been minimized.

Copy link

commented Jun 14, 2018

Same question as @Daadler6 I'm on sdk 26 with expokit.

@MorganDream

This comment has been minimized.

Copy link

commented Jun 15, 2018

My case is where expokit tag is ios/2.3.3, how should fix this?

@MorganDream

This comment has been minimized.

Copy link

commented Jun 15, 2018

@Daadler6 @poptocrack As root reason is FBAudienceNetwork, I found I can fix this by modify the version of FBAudienceNetwork to fixed value in Podfile.lock. 4.28.1 is good for me.

@pencilcheck

This comment has been minimized.

Copy link

commented Jun 17, 2018

Ditto @MorganDream, if you have older expokit, just modify Podfile.lock directly and change the version to 4.28.1 for FBAudienceNetwork and nuke Pods folder and rerun pod install then it will start working.

@lordcatalien

This comment has been minimized.

Copy link

commented Jun 18, 2018

Worked for me. Thank you @terribleben.

@dariuszseweryn

This comment has been minimized.

Copy link

commented Jun 22, 2018

@terribleben Can we have also a new patch version of ios/2.5.11?
Or the older versions of ExpoKit are not supported for 6 months? Our CI is configured in a way we do not keep Podfile.lock in the repo

expbot added a commit that referenced this issue Jul 20, 2018

Update to FBAudienceNetwork 4.99, add coverage (#2819)
Also related to #1868

fbshipit-source-id: 824bd4c

expbot added a commit to expo/expo-sdk that referenced this issue Jul 20, 2018

Update to FBAudienceNetwork 4.99, add coverage (#2819)
Also related to expo/expo#1868

fbshipit-source-id: 824bd4c
@sjchmiela

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2018

The neweset version of ExpoKit supports FBAudienceNetwork 4.99.0. Happy programming!

@sjchmiela sjchmiela closed this Aug 1, 2018

expbot added a commit to expo/expo-docs that referenced this issue Aug 14, 2018

@faustoct

This comment has been minimized.

Copy link

commented Sep 21, 2018

is the lastest expo sdk30.0.0? Upgraded and not working

@sjchmiela

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Hey @faustoct! Yes, the latest Expo SDK is 30.0.0. What do you mean by not working? Have you followed all the steps from Upgrading Your App?

If you haven't fixed your problem yet, would you be willing to create a new issue with more issue details? 🙂

@faustoct

This comment has been minimized.

Copy link

commented Sep 28, 2018

Yes, it's working! Installed expo from scratch and it's working now.

@esamelson

This comment has been minimized.

Copy link
Member

commented Oct 9, 2018

FYI -- to anyone who is using Expo SDK 27 or below and is still running into this issue, if you cannot upgrade to a newer SDK, you should be able to get around this issue by editing your Podfile.lock to pin the version to 4.28.1 and then re-running pod install.

@redreceipt

This comment has been minimized.

Copy link

commented Apr 18, 2019

Ditto @MorganDream, if you have older expokit, just modify Podfile.lock directly and change the version to 4.28.1 for FBAudienceNetwork and nuke Pods folder and rerun pod install then it will start working.

I manually upgraded FBAudienceNetwork because I'm on SDK 26 and now I'm getting new build errors:

Screen Shot 2019-04-18 at 3 15 22 PM

@zamgill

This comment has been minimized.

Copy link

commented Apr 23, 2019

FYI -- to anyone who is using Expo SDK 27 or below and is still running into this issue, if you cannot upgrade to a newer SDK, you should be able to get around this issue by editing your Podfile.lock to pin the version to 4.28.1 and then re-running pod install.

I tried doing that but i'm getting the following error when running "pod install" after:
image

@redreceipt

This comment has been minimized.

Copy link

commented Apr 23, 2019

@zamgill paste in your Podfile

@zamgill

This comment has been minimized.

Copy link

commented Apr 25, 2019

@redreceipt I was able to figure this out by upgrade to Expo SDK 28 and then using a new version of FBAudience. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.