Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need JavaScript Proxy support on Android (upgrade JSCore) #1874

Closed
rclai opened this issue Jun 14, 2018 · 14 comments

Comments

@rclai
Copy link

commented Jun 14, 2018

Mobx has just released version 5 which uses the Proxy object under the hood, but out of the box, Android doesn't have support for that
https://github.com/mobxjs/mobx#browser-support

So we have to upgrade JSCore manually but this is not doable in Expo
https://github.com/react-community/jsc-android-buildscripts#how-to-use-it-with-my-react-native-app

I would post this on Canny except it would take forever for it gain enough votes to even make it to your eyes in addition to how much less love Android gets in general.

Essentially anyone using Expo right now would be stuck in a sub version 5 of Mobx if this is not done.

Related issue: mobxjs/mobx#1587

@brentvatne

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

we updated a couple times in the past but there were bugs that forced us to revert the update. I think we will revisit this soon - it's being investigated right now and will hopefully make it for sdk29 but no guarantees.

@brentvatne

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

also, have you tried using a polyfill?

@rclai

This comment has been minimized.

Copy link
Author

commented Jun 14, 2018

The polyfill is not ideal because of the issues mentioned on here:
https://stackoverflow.com/questions/35025204/javascript-proxy-support-in-babel

TLDR

@brentvatne

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

fun! well, hopefully by sdk29 we'll have this in. that's about 5-6 weeks away if all goes well

@rclai

This comment has been minimized.

Copy link
Author

commented Jun 15, 2018

Great to hear!

@rclai rclai changed the title Need JavaScript Proxy support on Android Need JavaScript Proxy support on Android (upgrade JSCore) Jun 15, 2018

@TareqElMasri

This comment has been minimized.

Copy link

commented Jul 25, 2018

What's the update for this?

@mekwall

This comment has been minimized.

Copy link

commented Aug 3, 2018

@brentvatne Since this didn't make it into SDK 29, when are we expected to see it? And please, update the docs at least. We upgraded to MobX 5 because the docs say that both Symbol and Proxy are supported by JSC (on Android and iOS 10+) so we thought we were in the clear.

@skenan

This comment has been minimized.

Copy link

commented Aug 27, 2018

Any update?

@terrysahaidak

This comment has been minimized.

Copy link

commented Sep 7, 2018

Does the Expo SDK 30 include updated JSCore?

UPD: Seems like it is not.

@meepeek

This comment has been minimized.

Copy link

commented Sep 22, 2018

I am stuck in this issue as well.

@sjchmiela

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2018

Hey! Latest Expo SDK 31 has JSC upgraded to r224109. This is the highest we can confidently upgrade at the moment. Does this JSC version solve your issue? 🙂

@skenan

This comment has been minimized.

Copy link

commented Nov 7, 2018

@sjchmiela It solved the issue after upgrading to 31. Thank you!

@sjchmiela

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

Glad to hear that! 🎉

@sjchmiela sjchmiela closed this Nov 7, 2018

@rclai

This comment has been minimized.

Copy link
Author

commented Nov 9, 2018

Yay!

@lock lock bot added the outdated label Jun 13, 2019

@lock lock bot locked and limited conversation to collaborators Jun 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants
You can’t perform that action at this time.