Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release SDK33 #4154

Closed
sjchmiela opened this issue May 8, 2019 · 42 comments

Comments

Projects
None yet
@sjchmiela
Copy link
Contributor

commented May 8, 2019

SDK33 release plan

Release branch: sdk-33

SDK code related

  • drop obsolete SDKs
  • update react-native-gesture-handler
  • update lottie-react-native
  • update react-native-reanimated
  • update react-native-screens
  • update @react-native-community/netinfo
  • update @react-native-community/webview
  • update react-native-maps
  • update react-native-svg
  • update react-native
  • Generate new mocks and update jest-expo
  • Version Android code (@sjchmiela) (#4270)
  • Version iOS code (@tsapeta) (#4249)
  • QA Expo Client on iOS (@tsapeta)
  • QA Expo Client on Android (@sjchmiela)
  • Publish prerelease packages
  • Tag react-native fork sdk-33.0.0 (@ide)
  • Tag iOS ExpoKit (@tsapeta)
  • Publish !expo packages to npm (@sjchmiela)
  • Update expokit-npm-package (@sjchmiela)
  • Publish react-native-unimodules to npm (@sjchmiela)
  • Publish expo to npm (@sjchmiela, @tsapeta)
  • Test web in template projects and in general (@EvanBacon)

Launch blockers

  • [android][docs] determine if "mediaTypes" is ignore when launching a camera instead of library picker, update docs accordingly #4310
  • Import from expo-keep-awake instead of expo in AppEntry #4308
  • [android] Creating a calendar event throws a NPE if eventUri is null #4305
  • [docs] Add pitchCorrectionQuality to expo-av #4307
  • [android] Signing in with Facebook login seems not to work #4306

Infrastructure related

  • Update schema on staging (@sjchmiela)
  • Deploy schema to production (@sjchmiela)
  • Release xdl and expo-cli (@sjchmiela)
  • Publish dev and prod home (@tsapeta)
  • Push iOS Turtle to staging (@tsapeta)
  • Push Android Turtle to staging (@sjchmiela)
  • Release new project templates
  • Update ExpoKit Android on staging (@sjchmiela)
  • Update ExpoKit iOS on staging (@tsapeta)
  • Update ExpoKit AdHoc iOS on staging (@tsapeta)
  • Update versions on staging
  • Publish NCL to Apple's account (@tsapeta)
  • Update Home to show web projects
  • Submit for Apple review (@tsapeta)
  • Release iOS in App Store (@tsapeta)
  • Rollout Expo Client build for Simulator (add back bg location) (@tsapeta)
  • Push Android ExpoKit (@sjchmiela)
  • Add Android apk (@sjchmiela)
  • Release Android in Play Store (workflow) (@sjchmiela)
  • Mark old SDK as deprecated on server (@sjchmiela)
  • Promote versions to prod
  • Add SDK33 support to Snack (@tcdavis)
  • Release iOS Turtle to prod
  • Release Android Turtle to prod (@sjchmiela)
  • Release turtle-cli
  • Test ad-hoc builds (@quinlanj)
  • Add note about gulp update-react-native-unimodules-expokit to the release documentation (@sjchmiela)

Information related

  • Prepare changelog (@sjchmiela)
  • Review changelog (@tsapeta)
  • Publish NCL to @ community account
  • Add release notes to docs
  • Publish blog post with release notes (@ide, @esamelson)
  • Update React Native docs for this SDK (@tsapeta)
  • Publish new docs (@tsapeta)\
  • Promote new docs to prod
  • Update website front page
  • Post on Twitter
@raajnadar

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Will sdk 33 be using react native v0.59.7??

The keyboard avoiding view issue is fixed here (after 1 year) facebook/react-native@7140a7f

@ide

This comment has been minimized.

Copy link
Member

commented May 9, 2019

SDK 33 will use 0.59.8 and pin it there unless there is a critical bug (ex: many apps crashing) that requires an update. Any other upgrades will go out in a future SDK.

@serranoarevalo

This comment has been minimized.

Copy link

commented May 10, 2019

Any ETA for SDK 33?

@spyshower

This comment was marked as disruptive content.

Copy link

commented May 10, 2019

I hope we will get some fixes to the countless errors at the moment right?

Edit: I guess some people don't want fixes :)

@DevUsmanGhani

This comment has been minimized.

Copy link

commented May 12, 2019

Will there be anything regarding Background Location on android? There are a few threads with people having unresolved problems with getting Background Location to work on android. The task will only fire once when the app goes to the background and then not again even though it works fine on IOS.

Edit: I see this PR seems promising for this: #3837

@sjchmiela sjchmiela pinned this issue May 13, 2019

@Gad0005

This comment has been minimized.

Copy link

commented May 13, 2019

Having same issue as @DevUsmanGhani . IOS background task seems to be firing appropriately, but I can only get Android to fire background task once. The time it does fire once, it happens "immediately" after you select the "home" button....beyond that, I cant seem to get it to fire anymore.

@tsapeta

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@DevUsmanGhani @Gad0005 Yes, #3837 is hopefully going to resolve this issue on Android - you will need to use foregroundService option that was added in this pull request.

@Gad0005

This comment has been minimized.

Copy link

commented May 13, 2019

OK, no problem, Ill try the pull request and stay tuned for anything additional that comes up! Thanks for the update!

@maxcaluva

This comment has been minimized.

Copy link

commented May 15, 2019

Any ETA in this one?

@ide

This comment has been minimized.

Copy link
Member

commented May 16, 2019

We don't have an ETA but if you are interested in updates, either subscribe to this issue or to the Expo blog (https://blog.expo.io), which is where we post updates if there are any to share.

@mohsinriaz17

This comment has been minimized.

Copy link

commented May 17, 2019

so it will support 64-bit builds as opposed to the statement?

After SDK 33, we are also looking to support 64-bit APKs in time for Google’s upcoming requirement, which is also made easier by dropping older SDK versions.

64-bit builds will be supported "In SDK 33" instead of "After SDK 33" ?
https://blog.expo.io/preview-upcoming-changes-for-expo-sdk-33-67a4bac611a4

@tsapeta

This comment has been minimized.

Copy link
Member

commented May 17, 2019

The statement in the blog post is correct, we will be working on 64-bit support right after the release of SDK33.

@mohsinriaz17

This comment has been minimized.

Copy link

commented May 20, 2019

The statement in the blog post is correct, we will be working on 64-bit support right after the release of SDK33.

and what are the chances that 64-bit support will be available before or during August? for binaries for Google Play store

tsapeta added a commit that referenced this issue May 21, 2019

[sdk33] Version iOS code for SDK33 (#4249)
# Why

Step of #4154 

# How

`gulp ios-add-version --abi 33.0.0`

# Test Plan

Versioning script passes, project builds and `native-component-list` for SDK33 launches as expected.
@dellwatson

This comment has been minimized.

Copy link

commented May 22, 2019

i wish bottomsheet for Android is here or similar, im waiting an Android version like ActionSheetIOS for android with native looking

@harisvsulaiman

This comment has been minimized.

Copy link

commented May 22, 2019

i wish bottomsheet for Android is here or similar, im waiting an Android version like ActionSheetIOS for android with native looking

You build one yourself with react native gesture handler. Or use action from @expo organisation

@yareyaredesuyo

This comment has been minimized.

Copy link

commented May 22, 2019

Maybe release next month?

I think it is a good idea to add react-hooks template or example.
Because react-hooks is awesome feature and reduce a lot of boilerplate codes.

@oshimayoan

This comment has been minimized.

Copy link

commented May 23, 2019

@dellwatson Isn't Expo already has one?
Take a look at this one https://github.com/expo/react-native-action-sheet.

@sjchmiela sjchmiela referenced this issue May 23, 2019

Merged

[sdk33] Add versioned SDK33 to Android #4270

2 of 2 tasks complete

sjchmiela added a commit that referenced this issue May 23, 2019

[sdk33] Add versioned SDK33 to Android (#4270)
# Why

A step of #4154.

# How

After fixing `tools`, `gulp android-add-rn-version --abi=33.0.0`

# Test Plan

- [x] The project compiles
- [x] A sample SDK33 app runs

# Commits

* [android] Update versioned-react-native

* [android] Enable Java 1.8 in expoview

* [expokit] Update expokit-npm-package with SDK33

* [android] Upgrade Gradle wrapper in versioned-react-native

* [android] Upgrade Gradle tool in versioned-react-native

* [tools] Do not add another ADD_NEW_SDKS_HERE template string when versioning

* [tools] Update XDL and change JNI libraries in whole versioned-RN project

* [tools] Add support for Kotlin files when renaming packages

* [tools] Add support for Java 1.8 using a patched version of JarJar Links

React Native 0.59.8 added source and target compatibility to Java 1.8.

It looks like JarJar Links 1.4 (https://code.google.com/archive/p/jarjar),
which we use to rename versioned.host.exp. to abiXX_X_X.host.exp.
doesn't support Java 1.8 JARs. (See https://code.google.com/archive/p/jarjar/issues/64
and https://code.google.com/archive/p/jarjar/issues/63). Fortunately,
@mike-hogan patched JarJar Links --- updated ASM dependency from v4 to v5
so it supports new classes. I cloned the repository (https://github.com/m081072/jarjar-fork),
built the JAR with `ant` and copied `dist/jarjar-1.4.1.jar` to `tools`.

* [android] Remove react-native-unimodules reference when versioning

* [android] Run gulp android-add-rn-version --abi=33.0.0

* [android] Some post-adding-new-version patches to the project

* [tools] Fix add-stripe-activity script

* [expokit] Update expokit-npm-package with SDK33
@karanpratapsingh

This comment has been minimized.

Copy link

commented May 23, 2019

Waiting for sdk33, hope this releases soon

@spyshower

This comment was marked as disruptive content.

Copy link

commented May 25, 2019

@yareyaredesuyo More like October.

@dellwatson

This comment has been minimized.

Copy link

commented May 25, 2019

@oshimayoan but it was using iOS interface, so it doesn't feel like a native in android without using android's taste

@xiCO2k

This comment has been minimized.

Copy link

commented May 28, 2019

Hey guys, thanks for the awesome job, how much days left to have it? Thanks

@raajnadar

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

The ipa is submitted for review the estimated time is 1 week. They said android is causing a lot of blocker for rn upgrade in their blog post. And the sdk-33 branch is cut.

@stevelizcano

This comment has been minimized.

Copy link

commented May 29, 2019

I use just ExpoKit- is it possible to upgrade that now since the branch is cut?

@tomas-petrovcin

This comment has been minimized.

Copy link

commented May 29, 2019

I use just ExpoKit- is it possible to upgrade that now since the branch is cut?

@stevelizcano
Check the release blog posts, there's always update guide for ExpoKit as well :)

@ken0x0a

This comment has been minimized.

Copy link

commented May 31, 2019

I think, I'm checking this issue more than once a day. I can't wait upgrading!!

@karanpratapsingh

This comment has been minimized.

Copy link

commented Jun 1, 2019

@ken0x0a IKR, same 😆

@cmacdonnacha

This comment has been minimized.

Copy link

commented Jun 1, 2019

Anyone else seeing any issue with google sign in after updated to the latest Expo client in the play store?

@brentvatne

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

@cmacdonnacha - care to elaborate in a new issue?

@cmacdonnacha

This comment has been minimized.

Copy link

commented Jun 3, 2019

@brentvatne I created a post on the Expo forum: https://forums.expo.io/t/latest-expo-client-crashes-when-trying-to-google-sign-in/23332

I'm on Expo SDK 31 and after updated to Expo Client version 2.11.0 google sign in no longer works. It worked fine before that and didn't change any code my side. The android build also works fine, just not when using the expo client app. Someone else on that forum is also seeing the same issue. So it sounds like something was broken in the latest Expo client.

@YajanaRao

This comment has been minimized.

Copy link

commented Jun 4, 2019

Any update on background audio player?

@karanpratapsingh

This comment has been minimized.

Copy link

commented Jun 4, 2019

@YajanaRao I hope so, It's been under progress since 2018 June

@brettdh

This comment has been minimized.

Copy link

commented Jun 4, 2019

@YajanaRao @karanpratapsingh The relevant PR is mentioned in the changelog and present in the docs, so it's looking good to me (though I haven't tested it yet).

@karanpratapsingh

This comment has been minimized.

Copy link

commented Jun 4, 2019

@brettdh

This comment has been minimized.

Copy link

commented Jun 4, 2019

@karanpratapsingh

This comment has been minimized.

Copy link

commented Jun 4, 2019

tsapeta added a commit that referenced this issue Jun 4, 2019

[sdk33][docs] generate docs for SDK33 (#4410)
# Why

Step of #4154 

# How

Run `et generate-sdk-docs --sdk 33.0.0 --update-react-native-docs`

# Test Plan

We will see on the website 😅
@cmacdonnacha

This comment has been minimized.

Copy link

commented Jun 4, 2019

Hey guys, this could be a blocker before releasing SDK 33 though: https://forums.expo.io/t/latest-expo-client-crashes-when-trying-to-google-sign-in/23332/4

@waryong322

This comment has been minimized.

Copy link

commented Jun 5, 2019

when I use expo sdk33 through expo-cli

I waiting long long time

please

@ide

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@cmacdonnacha we are looking into the sign-in issue (it's related to an Android screenOrientation setting on Android 8+) as the final blocker for the Android release.

@esamelson

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

SDK 33 is out!! Check out the release notes here. Please direct all questions to the forums and report issues by opening a new issue ticket on GitHub, rather than commenting further on this issue 🙂

Thanks for all your patience and excitement, everyone! We are so excited to finally share this release with you all 🎉

@ide ide closed this Jun 6, 2019

@ide ide unpinned this issue Jun 6, 2019

@karanpratapsingh

This comment has been minimized.

Copy link

commented Jun 6, 2019

@cmacdonnacha

This comment has been minimized.

Copy link

commented Jun 6, 2019

Nice work guys!

@dctalbot

This comment has been minimized.

Copy link

commented Jun 17, 2019

Looks like on https://expo.io/tools under "Expo SDK supported versions" you should link the release notes: https://blog.expo.io/expo-sdk-v33-0-0-is-now-available-52d1c99dfe4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.