Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native-datetimepicker to SDK #4691

Open
brentvatne opened this issue Jun 22, 2019 · 2 comments

Comments

@brentvatne
Copy link
Member

commented Jun 22, 2019

Another set of APIs extracted in lean core, another lib we need to add.

@brentvatne brentvatne added this to To do in SDK 34 via automation Jun 22, 2019
@tsapeta tsapeta self-assigned this Jul 2, 2019
@tsapeta

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Unfortunately, this lib uses AndroidX that we can't use right now. We will need to upgrade our project to use AndroidX before we get it into our codebase. Related issue: #2956
Let's postpone this to SDK35.

@tsapeta tsapeta added this to To do in SDK 35 via automation Jul 5, 2019
@tsapeta tsapeta removed this from To do in SDK 34 Jul 5, 2019
@tsapeta tsapeta added this to To do in SDK 36 via automation Sep 5, 2019
@tsapeta tsapeta removed this from To do in SDK 35 Sep 5, 2019
@brentvatne

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2019

we should add this for sdk36 as react-native 0.61 is probably going to be the last release to include date picker components in core. so if we add this for sdk36 we give people a release where they can use either react-native-datetimepicker or the core components, which makes it easier to transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SDK 36
  
To do
2 participants
You can’t perform that action at this time.