Its not redirecting to mobile app after Google login, instead it goes to google.com #5032

reactexcel · 2019-07-22T10:15:18Z

Sorry @cruzach to open this issue again, i need to open this issue again as:
still its not working
here is my code :-

try {
const result = await Google.logInAsync({
androidClientId:"xxxx",
scopes: ['profile', 'email'],
redirectUrl:${AppAuth.OAuthRedirect}:/oauth2redirect/google
});
console.log(result);
} catch(e) {
console.log({e});
}
i did not make any change in node_modules.
and one more question , what should be the package name in production mode?
As now i am using host.exp.exponent for dev mode and com.xxxx(as it is in app.json) so is it right?
Thanks

The text was updated successfully, but these errors were encountered:

martin9908 · 2019-07-22T10:43:04Z

Google.loginAsync is already deprecated please use GoogleSignIn for google authentication, just follow this link on how to update your code: https://docs.expo.io/versions/v33.0.0/sdk/google-sign-in/

reactexcel · 2019-07-22T12:31:30Z

no @martin9908 its not deprecated its working fine, just not redirecting to app after google login
also i was trying google login with https://docs.expo.io/versions/v33.0.0/sdk/google-sign-in/
but getting error after first login that's it Error : there is some asyn operation still in progress
and then its failed again and again.
Please help me out i have spend a week got the google login
but bad luck!
Thanks.

cruzach · 2019-07-22T12:35:04Z

You need to pass the redirectUrl as a string, easiest would be to use JavaScript template strings

reactexcel · 2019-07-22T12:42:46Z

i have already done this but still going to google.com after login
@cruzach please help me i am so worry about this.
see here is my code

try {
const result = await Google.logInAsync({
androidClientId:"xxxx",
scopes: ['profile', 'email'],
redirectUrl:${AppAuth.OAuthRedirect}:/oauth2redirect/google
});
console.log(result);
} catch(e) {
console.log({e});
}

reactexcel · 2019-07-22T12:49:47Z

@cruzach
i am already using the template string as you made the changes in the pr

check my App.json once , i am using sdk32

{
"expo": {
"name": "xxxx",
"slug": "eventapp",
"privacy": "public",
"sdkVersion": "32.0.0",
"platforms": [
"ios",
"android"
],
"facebookAppId": "xxxxx",
"facebookDisplayName": "xxxxx",
"facebookScheme": "xxxxx",
"icon":"./assets/images/icon_events-channel.png",
"version": "1.0.0",
"orientation": "portrait",
"splash": {
"image": "./assets/images/splash1.png",
"resizeMode": "cover"
},
"notification": {
"icon": "./assets/images/ic_stat_call_whitee.png",
"color":"#FF6CC9"
},
"android": {
"package":"com.xxxx",
"googleServicesFile":"./assets/google-services.json",
"permissions" : [
"ACCESS_FINE_LOCATION",
"READ_EXTERNAL_STORAGE",
"MANAGE_DOCUMENTS",
"WRITE_EXTERNAL_STORAGE",
"CAMERA",
"CALENDAR",
"READ_CALENDAR",
"WRITE_CALENDAR"
]
},
"updates": {
"fallbackToCacheTimeout": 0
},
"assetBundlePatterns": [
"**/*"
],
"ios": {
"bundleIdentifier":"xxx",
"supportsTablet": true,
"config":{
"googleSignIn":{
"reservedClientId":"xxx"
}
},
"infoPlist": {
"NSCameraUsageDescription": "xxx needs your permissiom to access camera for uploading user profile."
}
}
}
}

and Package.json

{
"main": "node_modules/expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"eject": "expo eject",
"test": "node ./node_modules/jest/bin/jest.js --watchAll"
},
"jest": {
"preset": "jest-expo"
},
"dependencies": {
"@expo/samples": "2.1.1",
"axios": "^0.18.0",
"expo": "^32.0.0",
"expo-app-auth": "^5.0.1",
"expo-facebook": "^4.0.0",
"expo-google-app-auth": "^6.0.0-rc.0",
"immutability-helper": "^3.0.0",
"lodash": "^4.17.11",
"moment": "^2.24.0",
"react": "16.5.0",
"react-native": "https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz",
"react-native-autocomplete-input": "^3.6.0",
"react-native-get-location": "^1.1.2",
"react-native-image-picker": "^0.28.1",
"react-native-modalbox": "^1.7.1",
"react-native-snap-carousel": "^3.7.5",
"react-native-timer": "^1.3.6",
"react-native-touch": "0.0.2",
"react-native-unimodules": "^0.4.2",
"react-navigation": "^3.0.9",
"react-redux": "^6.0.0",
"redux": "^4.0.1",
"redux-actions": "^2.6.4",
"redux-logger": "^3.0.6",
"redux-saga": "^1.0.1"
},
"devDependencies": {
"babel-preset-expo": "^5.0.0",
"jest-expo": "^32.0.0"
},
"private": true
}

cruzach · 2019-07-22T15:53:54Z

@reactexcel - please don't open new issues, it doesn't increase the response time. You still haven't followed the issue template which we provide for you. Please go back and edit your post to include all of the information we ask for, formatted correctly. In the meantime, I see you're using SDK 32. Could you test your code on an SDK 33 project, and let me know if you hit the same error?

Also- it's really helpful to place "```" before and after your code that you are sharing, as that formats it very nicely.

reactexcel · 2019-07-23T07:42:32Z

ok won't create the same issue
and thanks for the reply @cruzach

as you told me to check it with sdk33, i check it on dev mode but getting no response (no error no response).
its really more bad than with sdk32

reactexcel · 2019-07-23T08:42:08Z

and @cruzach please can you tell me why is GoogleSignIn giving an error of some async operation are still in pending.

cruzach · 2019-07-23T15:37:31Z

as you told me to check it with sdk33, i check it on dev mode but getting no response (no error no response).

You've most likely misconfigured something in the setup here. I would go through the docs and make sure you've followed each step.

please can you tell me why is GoogleSignIn giving an error of some async operation are still in pending.

Without a way to reproduce it on my end, I can't say why this would/is happening.

cberigan · 2019-08-26T17:22:37Z

I too am seeing this issue. It's only happening in android standalone apps. Upon closer inspection, the expo-app-auth module generates a default redirect url as ${ExpoAppAuth.OAuthRedirect}:/oauthredirect while the expo-google-app-auth module generates a default redirect url as ${reverseClientId}:/oauth2redirect/google. Looks like a bug to me.

I've provided a solution on my end by using ${AppAuth.OAuthRedirect}:/oauthredirect as the redirectUrl.

cruzach · 2019-08-26T17:41:20Z

@cberigan can you provide a way for me to reproduce this?

cberigan · 2019-08-26T18:40:44Z

@cruzach Let me put something together. It may take me a day or 2.

cberigan · 2019-08-26T22:40:52Z

google-auth-test.zip

@cruzach Attached is a sample project. Just build the expo project for android, install, and run. The App.js contains some comments to reproduce.

cruzach · 2019-08-27T21:44:17Z

@cberigan - the standalone build failed 😕

cberigan · 2019-08-27T22:36:24Z

What was the issue? I was able to build it on android.

cruzach · 2019-08-28T14:47:43Z

Fixed the build issue, it was on my end

The issue you're seeing is the same as 4655, which was fixed in this PR (it just hasn't been published yet)

Manually made the PR change to the node_modules/expo-google-app-auth package, published, and the app works as intended

santhoshvkumar · 2019-09-06T12:02:18Z

Is there is any round around approach for solving this issue? I just updated the application to 34.0.0. It's redirecting to the google.com, If there is any temporary fix that would be helpful.

cruzach · 2019-09-06T17:20:35Z

You can pass ${AppAuth.OAuthRedirect}:/oauth2redirect/google in as your redirectUrl for a temporary workaround (for standalone apps)

vinagrito · 2019-09-10T08:54:52Z

@cruzach The fix you made on the merged PR makes sense and after changing my code I can see that the config passed into the logInAsync function is the expected one - com.example.my-example:/oauth2redirect/google.
And yet my app keeps redirecting to google.com. Same as @santhoshvkumar I'm on the latest versions of the SDK and the expo-google-app-auth library

cberigan · 2019-09-10T13:08:57Z

@vinagrito Read my comment. Use ${AppAuth.OAuthRedirect}:/oauthredirect as the redirectUri. If in doubt, download the project zip in one of my comments and it has both the reproduced bug and solution

vinagrito · 2019-09-10T15:12:18Z

@cberigan indeed the test app you posted works as expected 😄. Should I believe then my oauth clients are not configured correctly?. Should my API key be restricted to android apps?. Also, I see that the app.json reads:

...
"android": {
     "package": "com.testapp.expogoogleauthbug"
  }

I don't see a config.googleSignIn attribute there... According to https://docs.expo.io/versions/latest/sdk/google/#deploying-to-a-standalone-app-on-android I need to those defined.

vinagrito · 2019-09-10T17:14:49Z

@cberigan Is there a correlation between the SHA1 hash in expo used for the signing with the one defined in the google developer oauth client ID?

vinagrito · 2019-09-10T18:30:52Z

@cberigan OK, so I managed to fix it. My identifier contains a capital letter, kind of a:
com.myCoolidentifier.identifier so I was pasting the same value in the oauth client ID. well, seems like that's not valid. So I just lowered case everything and that's it for now

andersco · 2019-09-20T22:51:43Z

@cberigan OK, so I managed to fix it. My identifier contains a capital letter, kind of a:
com.myCoolidentifier.identifier so I was pasting the same value in the oauth client ID. well, seems like that's not valid. So I just lowered case everything and that's it for now

@vinagrito that was my issue too...thanks for posting this!

kgpasta · 2019-10-22T20:09:10Z

@vinagrito @andersco which oauth client ID did you end up changing? I'm having the same issue, and we also have a capital letter in our identifier, but changing it in the Google Developer Console seems to have no effect

andersco · 2019-10-26T20:59:57Z

@kgpasta I changed the package name in my oauth client ID that is used for Android (not expo) to be all lowercase and that fixed the issue for me.

kgpasta · 2019-11-01T01:57:40Z

thanks @andersco that fixed it!

cruzach mentioned this issue Jul 22, 2019

Error : there is some async operations still in progress after first login with GoogleSignIn.signInAsync #5036

Closed

cruzach added needs repro needs more info To be used when awaiting reporter response labels Jul 22, 2019

cruzach closed this as completed Aug 28, 2019

lock bot added the outdated label May 5, 2020

lock bot locked and limited conversation to collaborators May 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Its not redirecting to mobile app after Google login, instead it goes to google.com #5032

Its not redirecting to mobile app after Google login, instead it goes to google.com #5032

reactexcel commented Jul 22, 2019 •

edited

martin9908 commented Jul 22, 2019

reactexcel commented Jul 22, 2019

cruzach commented Jul 22, 2019 •

edited

reactexcel commented Jul 22, 2019 •

edited

reactexcel commented Jul 22, 2019 •

edited

cruzach commented Jul 22, 2019

reactexcel commented Jul 23, 2019

reactexcel commented Jul 23, 2019

cruzach commented Jul 23, 2019

cberigan commented Aug 26, 2019 •

edited

cruzach commented Aug 26, 2019

cberigan commented Aug 26, 2019

cberigan commented Aug 26, 2019 •

edited

cruzach commented Aug 27, 2019

cberigan commented Aug 27, 2019

cruzach commented Aug 28, 2019

santhoshvkumar commented Sep 6, 2019

cruzach commented Sep 6, 2019 •

edited

vinagrito commented Sep 10, 2019 •

edited

cberigan commented Sep 10, 2019

vinagrito commented Sep 10, 2019 •

edited

vinagrito commented Sep 10, 2019

vinagrito commented Sep 10, 2019

andersco commented Sep 20, 2019

kgpasta commented Oct 22, 2019

andersco commented Oct 26, 2019

kgpasta commented Nov 1, 2019

Its not redirecting to mobile app after Google login, instead it goes to google.com #5032

Its not redirecting to mobile app after Google login, instead it goes to google.com #5032

Comments

reactexcel commented Jul 22, 2019 • edited

martin9908 commented Jul 22, 2019

reactexcel commented Jul 22, 2019

cruzach commented Jul 22, 2019 • edited

reactexcel commented Jul 22, 2019 • edited

reactexcel commented Jul 22, 2019 • edited

cruzach commented Jul 22, 2019

reactexcel commented Jul 23, 2019

reactexcel commented Jul 23, 2019

cruzach commented Jul 23, 2019

cberigan commented Aug 26, 2019 • edited

cruzach commented Aug 26, 2019

cberigan commented Aug 26, 2019

cberigan commented Aug 26, 2019 • edited

cruzach commented Aug 27, 2019

cberigan commented Aug 27, 2019

cruzach commented Aug 28, 2019

santhoshvkumar commented Sep 6, 2019

cruzach commented Sep 6, 2019 • edited

vinagrito commented Sep 10, 2019 • edited

cberigan commented Sep 10, 2019

vinagrito commented Sep 10, 2019 • edited

vinagrito commented Sep 10, 2019

vinagrito commented Sep 10, 2019

andersco commented Sep 20, 2019

kgpasta commented Oct 22, 2019

andersco commented Oct 26, 2019

kgpasta commented Nov 1, 2019

reactexcel commented Jul 22, 2019 •

edited

cruzach commented Jul 22, 2019 •

edited

reactexcel commented Jul 22, 2019 •

edited

reactexcel commented Jul 22, 2019 •

edited

cberigan commented Aug 26, 2019 •

edited

cberigan commented Aug 26, 2019 •

edited

cruzach commented Sep 6, 2019 •

edited

vinagrito commented Sep 10, 2019 •

edited

vinagrito commented Sep 10, 2019 •

edited