Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo vector icons are broken on Edge #5935

Closed
d4rky-pl opened this issue Oct 9, 2019 · 3 comments 路 Fixed by #5961

Comments

@d4rky-pl
Copy link

commented Oct 9, 2019

馃悰 Bug Report

Environment

  Expo CLI 3.1.2 environment info:
    System:
      OS: macOS 10.14.6
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 8.11.3 - /var/folders/qt/10542x9d2wbg0x93mmh1xsw00000gn/T/yarn--1570620719131-0.9749200633049342/node
      Yarn: 1.17.3 - /var/folders/qt/10542x9d2wbg0x93mmh1xsw00000gn/T/yarn--1570620719131-0.9749200633049342/yarn
      npm: 5.6.0 - ~/.asdf/shims/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    IDEs:
      Android Studio: 3.5 AI-191.8026.42.35.5791312
      Xcode: 11.0/11A420a - /usr/bin/xcodebuild
    npmPackages:
      expo: ^35.0.0 => 35.0.0
      react: 16.8.3 => 16.8.3
      react-native: https://github.com/expo/react-native/archive/sdk-35.0.0.tar.gz => 0.59.8
    npmGlobalPackages:
      expo-cli: 3.1.2

Issue reproduced on Edge 44 on Windows 10 (both on regular PC and using official VM)

Steps to Reproduce

  1. Import MaterialIcons from @expo/vector-icons and try to render one
  2. Open the page in Microsoft Edge

Expected Behavior

Icon is visible

Actual Behavior

TTF file is loaded but the icon is not showing up.

Additionally, but this is not happening in the reproducible demo, in our case we've got a bunch of "3000ms timeout exceeded" errors in the console.

Reproducible Demo

https://github.com/d4rky-pl/expo-web-broken-icons

@d4rky-pl

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

@cruzach cruzach transferred this issue from expo/expo Oct 9, 2019
@d4rky-pl

This comment has been minimized.

Copy link
Author

commented Oct 10, 2019

@cruzach this is an issue with expo-font, not with @expo/vector-icons. The fact icon is not visible is due to Font.loadAsync(font) failing even though the font is actually being fetched and loaded properly

@cruzach

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Thanks! Seeing now that expo-font has fontfaceobserver as a dependency

@cruzach cruzach transferred this issue from expo/vector-icons Oct 10, 2019
@jkhales jkhales self-assigned this Oct 11, 2019
@EvanBacon EvanBacon assigned EvanBacon and unassigned jkhales Oct 11, 2019
@EvanBacon EvanBacon added the bug label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.